Merged
Conversation
Contributor
|
I think this makes a lot of sense, thanks. Could you maybe edit PR message with some context? Then it's ready |
carlopi
approved these changes
Jul 14, 2025
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Jul 14, 2025
Pending merge of duckdb/duckdb-vss#64 and duckdb/duckdb-azure#111
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Jul 15, 2025
Mytherin
added a commit
to duckdb/duckdb
that referenced
this pull request
Jul 15, 2025
…lib (#18205) Two not so independent changes: * bump `vcpkg-duckdb-ports` commit to include duckdb/vcpkg-duckdb-ports@fcdaf72, that adds: ```cmake set(CMAKE_CXX_WINDOWS_FLAGS "${CMAKE_CXX_WINDOWS_FLAGS} /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR") ``` to `vcpkg-cmake` port. * cherry-picks a tests by @staticlibs test to check whether correct flags are passed down to VCPKG (part of #18149) * remove `vss` and `azure` (PR that adapt them are ready, needs to be merged and then bumped, see duckdb/duckdb-vss#64 and duckdb/duckdb-azure#111) If Windows CI for this PR passes, then good to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manage overlay ports via central registry: https://github.com/duckdb/vcpkg-duckdb-ports
This is part of a process to homogenize extension CI
https://github.com/duckdblabs/duckdb-internal/issues/5307