Enable extensions test run with VS2019 C++ stdlib#18149
Closed
staticlibs wants to merge 1 commit intoduckdb:v1.3-ossivalisfrom
Closed
Enable extensions test run with VS2019 C++ stdlib#18149staticlibs wants to merge 1 commit intoduckdb:v1.3-ossivalisfrom
staticlibs wants to merge 1 commit intoduckdb:v1.3-ossivalisfrom
Conversation
ea1d775 to
06db992
Compare
2dab6f9 to
784b7d1
Compare
This change enbales additional run of the test suite for all extensions using C++ stdlib DLL from Visual Studion 2019. This is done to check the compatibility with older versions of C++ stdlib introduced in duckdb#17991 New workflow step is only run for `x64-windows-static-md` build arch. Testing: it was checked in manual CI runs, that added unit test run actually causes a crash when `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` is not used.
e50d319 to
d0f8a4b
Compare
Contributor
Author
|
Closing as superseded by #18205. |
Mytherin
added a commit
that referenced
this pull request
Jul 15, 2025
…lib (#18205) Two not so independent changes: * bump `vcpkg-duckdb-ports` commit to include duckdb/vcpkg-duckdb-ports@fcdaf72, that adds: ```cmake set(CMAKE_CXX_WINDOWS_FLAGS "${CMAKE_CXX_WINDOWS_FLAGS} /D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR") ``` to `vcpkg-cmake` port. * cherry-picks a tests by @staticlibs test to check whether correct flags are passed down to VCPKG (part of #18149) * remove `vss` and `azure` (PR that adapt them are ready, needs to be merged and then bumped, see duckdb/duckdb-vss#64 and duckdb/duckdb-azure#111) If Windows CI for this PR passes, then good to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enbales additional run of the test suite for all extensions using C++ stdlib DLL from Visual Studion 2019. This is done to check the compatibility with older versions of C++ stdlib introduced in #17991.
New workflow step is only run for
x64-windows-static-mdbuild arch.Testing: it was checked in manual CI runs, that added unit test run actually causes a crash when
_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTORis not used.