HTTPFS: Move from HTTPException to base class IOException#9351
Merged
Mytherin merged 3 commits intoduckdb:mainfrom Oct 16, 2023
Merged
HTTPFS: Move from HTTPException to base class IOException#9351Mytherin merged 3 commits intoduckdb:mainfrom
Mytherin merged 3 commits intoduckdb:mainfrom
Conversation
This commit might need to be back-ported (at least for MacOS builds) to previous released httpfs extension binaries (most affected are v0.9.1 due to how this is put onto the spotlight due to duckdb#9286) to fix issue like duckdb#9340 My idea on how to proceed is as follow: this can be merged into duckdb and have nightly binaries (and connected extensions) throwing IOExceptions (that are properly handled) instead of specialised payload of HTTPExtensions This allows to test (on CI and on nightlies) whether this solves the actual problem This also allows, independently, to explore how to build specific extensions with a custom patch (this commit is basically the patch) Fixing the handling of HTTPExtension in core duckdb. Potentially this could mean axing the HTTP-specific payload and moving to a generic textual plus custom payload extracted via virtual function calls
cc47104 to
16c1a78
Compare
Collaborator
|
Thanks! |
samansmink
added a commit
to duckdb/duckdb_httpfs_wasm_experiment
that referenced
this pull request
Oct 17, 2023
Mytherin
added a commit
to Mytherin/duckdb
that referenced
this pull request
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit might need to be back-ported (at least for MacOS builds) to previous released httpfs extension binaries (most affected are v0.9.1 due to how this is put onto the spotlight due to #9286) to fix issue like #9340
My idea on how to proceed is as follow:
This allows to test (on CI and on nightlies) whether this solves the actual problem
This also allows, independently, to explore how to build specific extensions with a custom patch (this commit is basically
the patch)