Merged
Conversation
Contributor
Author
|
Note that this do not guarantees same behaviour in all cases between duckdb::Exception and std::exceptions with the right message, but should solve a big share of them while adding infrastructure to solve the remaining ones. Final part could be either done incrementally in the more relevant places or via adding appropriate testing where we toggle between throwing unwrapped std::exceptions or duckdb::Exception, and expect results to be the same. |
Tishj
reviewed
Oct 10, 2023
Mytherin
reviewed
Oct 10, 2023
Fixes duckdb#6521 Thanks to @Tishj for spotting a bug
5ae773b to
f6a93d7
Compare
Collaborator
|
Thanks! |
2 tasks
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Oct 15, 2023
This commit might need to be backported (at least for MacOS builds) to previous released httpfs extension binaries (most affected are v0.9.1 due to how this is put onto the spotlight due to duckdb#9286) to fix issue like duckdb#9340 My idea on how to proceed is as follow: 1. this can be merged into duckdb and have nightly binaries (and connected extensions) throwing IOExceptions (that are properly handled) instead of specialized payload of HTTPExtensions This allows to test (on CI and on nightlies) whether this solves the actual problem This also allows, independently, to explore how to build specific extensions with a custom patch (this commit is basically the patch) 2. Fixing the handling of HTTPExtension in core duckdb. Potentially this could mean axing the HTTP-specific payload and moving to a generic textual plus custom payload extracted via virtual funtion calls
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Oct 15, 2023
This commit might need to be back-ported (at least for MacOS builds) to previous released httpfs extension binaries (most affected are v0.9.1 due to how this is put onto the spotlight due to duckdb#9286) to fix issue like duckdb#9340 My idea on how to proceed is as follow: 1. this can be merged into duckdb and have nightly binaries (and connected extensions) throwing IOExceptions (that are properly handled) instead of specialised payload of HTTPExtensions This allows to test (on CI and on nightlies) whether this solves the actual problem This also allows, independently, to explore how to build specific extensions with a custom patch (this commit is basically the patch) 2. Fixing the handling of HTTPExtension in core duckdb. Potentially this could mean axing the HTTP-specific payload and moving to a generic textual plus custom payload extracted via virtual function calls
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Oct 15, 2023
This commit might need to be back-ported (at least for MacOS builds) to previous released httpfs extension binaries (most affected are v0.9.1 due to how this is put onto the spotlight due to duckdb#9286) to fix issue like duckdb#9340 My idea on how to proceed is as follow: this can be merged into duckdb and have nightly binaries (and connected extensions) throwing IOExceptions (that are properly handled) instead of specialised payload of HTTPExtensions This allows to test (on CI and on nightlies) whether this solves the actual problem This also allows, independently, to explore how to build specific extensions with a custom patch (this commit is basically the patch) Fixing the handling of HTTPExtension in core duckdb. Potentially this could mean axing the HTTP-specific payload and moving to a generic textual plus custom payload extracted via virtual function calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test this, add this as extension_config_local.cmake:
on the
mainduckdb branch, thenShould error like:
Error: Invalid Error: IO Error: GDAL Error (4): taxi_zones.shx: No such file or directorywhile doing the same from this branch should give:
Error: IO Error: GDAL Error (4): taxi_zones.shx: No such file or directory.Fixes #6521