Internal #6777: IEJoin Unified L1/2#20083
Merged
lnkuiper merged 18 commits intoduckdb:mainfrom Dec 11, 2025
Merged
Conversation
Contributor
hawkfish
commented
Dec 8, 2025
- Pull out L1/L2 construction to tasks (still single threaded)
- Convert IEJoinUnion to work on slices of L2
- Remove dead code.
- Cherry pick block iterator locking fix.
- Add resource requirements to test.
- Fix NOP memory race with placement new atomics.
- Fix missing include
* Pull out L1/L2 construction to tasks (still single threaded) * Convert IEJoinUnion to work on slices of L2 * Remove dead code.
* Add resource requirements.
* Fix NOP memory race with placement new atomics.
* Fix missing include
Contributor
Author
|
Benchmark trace showing parallel join task: 
|
lnkuiper
reviewed
Dec 8, 2025
Collaborator
lnkuiper
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks good, I just have one thing:
| auto &sort_key = static_cast<SORT_KEY &>(*this); | ||
| sort_key.payload.u.ptr = payload; | ||
| auto a = new ((void *)&sort_key.payload.u.ptr) atomic<data_ptr_t>; | ||
| a->store(payload); |
Collaborator
There was a problem hiding this comment.
I think we should wait for #20059 to be merged first, and then see if we can make ThreadSan CI succeed without the atomic hack. I must say, however, this is a very interesting hack!
Contributor
Author
There was a problem hiding this comment.
I had to remove the hack because it doesn't work on Windows for some reason (which is very strange because I first used it on Windows about 10 years ago.). I've added sanitiser rules for now and everything passes.
* Fix Windows atomic failure(?)
* Remove placement new atomics * Suppress data race warnings for sort payloads
Collaborator
|
I've merged with |
* Update data race suppression to just block the usual found match = true NOP.
…into iejoin-parallel
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Feb 16, 2026
Remove pointer indirection in ExtensionAccess (duckdb/duckdb#19529) fix: link error on linux with multiple definition of LogicalType::VARCHAR in `shell_renderer.cpp` (duckdb/duckdb#20096) Internal duckdb/duckdb#6777: IEJoin Unified L1/2 (duckdb/duckdb#20083)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Feb 16, 2026
Remove pointer indirection in ExtensionAccess (duckdb/duckdb#19529) fix: link error on linux with multiple definition of LogicalType::VARCHAR in `shell_renderer.cpp` (duckdb/duckdb#20096) Internal duckdb/duckdb#6777: IEJoin Unified L1/2 (duckdb/duckdb#20083) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.