Skip to content

Fix race condition in piecewise merge join#20059

Merged
Mytherin merged 8 commits intoduckdb:mainfrom
lnkuiper:internal_issue_6768
Dec 10, 2025
Merged

Fix race condition in piecewise merge join#20059
Mytherin merged 8 commits intoduckdb:mainfrom
lnkuiper:internal_issue_6768

Conversation

@lnkuiper
Copy link
Collaborator

@lnkuiper lnkuiper commented Dec 5, 2025

Fixes https://github.com/duckdblabs/duckdb-internal/issues/6768

Typically, all pointer recomputation happens within a lock, but because these pointers span two different collections, we need access to the lock from outside of the collection code.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft December 5, 2025 12:44
@lnkuiper lnkuiper marked this pull request as ready for review December 5, 2025 12:45
@Mytherin
Copy link
Collaborator

Mytherin commented Dec 5, 2025

Thanks! Can we also remove the require nothreadsan I added to test/optimizer/join_elimination.test?

@duckdb-draftbot duckdb-draftbot marked this pull request as draft December 8, 2025 08:35
@Mytherin Mytherin marked this pull request as ready for review December 8, 2025 09:25
@duckdb-draftbot duckdb-draftbot marked this pull request as draft December 8, 2025 09:41
@lnkuiper lnkuiper marked this pull request as ready for review December 9, 2025 08:01
@lnkuiper
Copy link
Collaborator Author

lnkuiper commented Dec 10, 2025

Failures are unrelated, but I'll wait until v1.4-andium has been merged into main

@Mytherin Mytherin merged commit 54473bc into duckdb:main Dec 10, 2025
76 of 79 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@lnkuiper lnkuiper deleted the internal_issue_6768 branch December 10, 2025 11:51
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jan 3, 2026
Fix race condition in piecewise merge join (duckdb/duckdb#20059)
Roaring boolean FetchRow fix (duckdb/duckdb#20101)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jan 3, 2026
Fix race condition in piecewise merge join (duckdb/duckdb#20059)
Roaring boolean FetchRow fix (duckdb/duckdb#20101)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants