[Fix] Rework transaction logic in commit, rollback and checkpoint paths#18474
Merged
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom Aug 1, 2025
Merged
[Fix] Rework transaction logic in commit, rollback and checkpoint paths#18474Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom
Mytherin merged 2 commits intoduckdb:v1.3-ossivalisfrom
Conversation
Collaborator
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 1, 2025
[Fix] Rework transaction logic in commit, rollback and checkpoint paths (duckdb/duckdb#18474) [Chore] Improve skipped tests in test config and add verify_fetch_row config (duckdb/duckdb#18436)
Contributor
|
I think the merging logic would need to be adapted to propagate the more problematic exception, instead of keeping the same exception type it has to start with. In particular for this codepath: try {
if (!error.HasError()) {
// Commit the transaction.
error = transaction_manager.CommitTransaction(context, transaction);
} else {
// Rollback due to previous error.
transaction_manager.RollbackTransaction(transaction);
}
} catch (std::exception &ex) {
error.Merge(ErrorData(ex));
}Say there is an error already entering this codepath, say an OutOfMemoryException, and say that RollbackTransaction throws something that should invalidate like a FatalException. Now instead of throwing a FatalException, an OutOfMemory is re-thrown, and this might end up being ignored. The other two codepaths I think after this PR are in a better state, but still can benefit from improved merging logic. |
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 1, 2025
[Fix] Rework transaction logic in commit, rollback and checkpoint paths (duckdb/duckdb#18474) [Chore] Improve skipped tests in test config and add verify_fetch_row config (duckdb/duckdb#18436) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close https://github.com/duckdblabs/duckdb-internal/issues/5437