[Chore] Improve skipped tests in test config and add verify_fetch_row config#18436
Merged
Mytherin merged 1 commit intoduckdb:v1.3-ossivalisfrom Jul 30, 2025
Merged
Conversation
Contributor
Author
|
I don't think the |
Collaborator
|
Looks great, thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 1, 2025
[Fix] Rework transaction logic in commit, rollback and checkpoint paths (duckdb/duckdb#18474) [Chore] Improve skipped tests in test config and add verify_fetch_row config (duckdb/duckdb#18436)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 1, 2025
[Fix] Rework transaction logic in commit, rollback and checkpoint paths (duckdb/duckdb#18474) [Chore] Improve skipped tests in test config and add verify_fetch_row config (duckdb/duckdb#18436) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Mytherin
added a commit
that referenced
this pull request
Aug 6, 2025
Looks like I didn't actually add the `verify_fetch_row.json` config to `Main.yml` in #18436.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
verify_fetch_row.jsonconfig:Close https://github.com/duckdblabs/duckdb-internal/issues/5207.
New structure of skipped tests:
Example:
{ "reason": "Contains FIRST (non-deterministic).", "paths": [ "test/sql/parallelism/intraquery/test_parallel_nested_aggregates.test" ] }, { "reason": "FIXME: Unexpected parsed statement verifier failure.", "paths": [ "test/sql/types/decimal/large_decimal_constants.test", "test/sql/types/uhugeint/test_uhugeint_conversion.test", "test/sql/types/hugeint/test_hugeint_conversion.test" ] },There are a bunch of
FIXMEin the newverify_fetch_row.json- I'll open the respective internal issues once we've merged this PR.