Add support for workspace inheritance#1185
Merged
drager merged 2 commits intodrager:masterfrom Jan 28, 2023
printfn:workspace-inheritance
Merged
Add support for workspace inheritance#1185drager merged 2 commits intodrager:masterfrom printfn:workspace-inheritance
drager merged 2 commits intodrager:masterfrom
printfn:workspace-inheritance
Conversation
|
Anything I can help to move this PR forward? |
Contributor
Author
|
It's blocked by #1188 |
Thanks for the update! |
Contributor
Author
|
Rebased onto #1188 and resolved the merge conflicts. |
|
will this one release a new version? like v0.11.0 🤔 |
Owner
Yes, will do that in a near future :) |
|
Hi there! Just would like to bump this up. How's the new release going? Anything I can help with it? can't wait to build our project with this feature 😎 |
panarch
added a commit
to gluesql/gluesql
that referenced
this pull request
Feb 10, 2023
Shares edition, description, license, repository and documentation fields ref. drager/wasm-pack#1185 so this commit changes does not contain wasm-pack related workspaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for reading metadata from crates using the workspace inheritance feature introduced in Rust 1.64.
I've implemented this by bumping the
cargo_metadatadependency to the latest version, and using its metadata for thedescription,license,license-file,repositoryandhomepagefields, instead of parsing theCargo.tomlfile directly. This should also makewasm-packmore resilient to futureCargo.tomlformat changes.I've tested the change locally and it seems to work perfectly.
Fixes #1180.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨