Fix binaryen URL and use updated binary-install to fix installation on macOS (adding to @matheus23's PR)#1188
Merged
drager merged 20 commits intodrager:masterfrom Jan 15, 2023
printfn:fix-binaryen
Merged
Fix binaryen URL and use updated binary-install to fix installation on macOS (adding to @matheus23's PR)#1188drager merged 20 commits intodrager:masterfrom printfn:fix-binaryen
binary-install to fix installation on macOS (adding to @matheus23's PR)#1188drager merged 20 commits intodrager:masterfrom
printfn:fix-binaryen
Conversation
binary-install to fix installation on macOS (adding to @matheus23's PR)binary-install to fix installation on macOS (adding to @matheus23's PR)
binary-install to fix installation on macOS (adding to @matheus23's PR)binary-install to fix installation on macOS (adding to @matheus23's PR)
Contributor
Author
|
Hi @drager, apologies for the ping. Do you think you might potentially be able to take a look at this PR? It’s gotten a bit large unfortunately due to the error handling changes, but I believe it should work now. Thanks! |
v0.3.7 no longer compiles as of Rust 1.64, see rust-lang/mdBook#1875
This was referenced Nov 26, 2022
joshuataylor
reviewed
Jan 8, 2023
|
I've been testing this on both MacOS Monterey ARM64 and Linux AMD64 and it works great! No issues so far. 👍 |
drager
approved these changes
Jan 14, 2023
Owner
drager
left a comment
There was a problem hiding this comment.
I think this looks good. Thanks a lot for all the work and effort!
Contributor
Author
|
Updated to use the new version of binary-install :) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes all the commits from #1163, uses the updated
binary-installcrate (drager/binary-install#21), switches fromfailuretoanyhowto match whatbinary-installuses, and fixeswasm-optinstallation on macOS.Close #1163
Close #1175
Close #1176
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨