Does it handle white space in the arguments correctly? For example if I call xharness adb -- "some arg with spaces" it should pass it as a single argument.

Good point. I blindly trusted the existing Android code but now I verified it and we were not doing this so I added quotation from Apple side (we unfortunately have different process managers 😥 for some reason)

I think the most correct way to handle this would be to keep the arguments as an array and use ProcessStartInfo.ArgumentList instead of Arguments. It's more errorproof than making sure that everything is quoted correctly.

Oooh, I was too fast and didn't even think for a second arguments is a string 😅

I see the failures in tests now:

Executing command: 'adb.exe  "devices -l"'

I think the most correct way would be to switch to a single implementation in this repo which would be the one coming from Xamarin that already does all this

@lpatalas I switched AdbRunner to accept an array of arguments instead. It uncovered many places where the code wasn't escaping potential problems in paths and other places.