Skip to content

Create android adb command #726

@premun

Description

@premun

Context

Sometimes we want to use the bundled ADB directly. Currently, we can call android state --adb to get path to the ADB executable and then run that.

Follow up of #724

Goals

  • Add the android adb command which would just forward the arguments to adb and pipe the output/exit code.
  • The command should accept XHarness arguments still (like -v or -h) and only forward the PassThroughArguments which are deliminated by -- so for example:
    xharness android adb -v -- devices list
    
  • We should make sure we run ADB in the same way we run programs in Apple, so with a ProcessManager
  • We need to make sure we pipe the output well and not buffer it in memory to prevent common CLI issues
  • Once this is finished, we should remove the --adb options from the android state command (revert that whole change)

Metadata

Metadata

Assignees

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions