Allow printing ADB path using xharness android state --adb#724
Merged
premun merged 1 commit intodotnet:mainfrom Sep 30, 2021
Merged
Allow printing ADB path using xharness android state --adb#724premun merged 1 commit intodotnet:mainfrom
xharness android state --adb#724premun merged 1 commit intodotnet:mainfrom
Conversation
MattGal
reviewed
Sep 29, 2021
Member
MattGal
left a comment
There was a problem hiding this comment.
Changes seem like a lot for what's happening here, especially given in the debug logging level it already logs where the exe is all the time. (You also changed mac stuff unrelated to the title of the PR?)
Why not just expose the path on Adbrunner like you have, and just log it in
, without all the rest of this?
src/Microsoft.DotNet.XHarness.CLI/CommandArguments/Android/Arguments/ShowAdbPathArgument.cs
Outdated
Show resolved
Hide resolved
1718c62 to
45ff1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for dotnet/arcade#7970 and for dotnet performance tests
Also drops "Get" from "*GetDevice" and "*GetState" commands to follow the rest of the commandset