Update Message to avoid common casting errors#5849
Merged
JeremyKuhne merged 2 commits intodotnet:mainfrom Sep 24, 2021
Merged
Conversation
Store PARAM and result as nint and expose internally. Add DEBUG obsoletion to flush out any usages of the IntPtr properties (and suppress in consuming projects). Note that the Message field names are deliberately named to match the properties for easier diffing in this PR. Other changes: - Add Point helpers to PARAM - Update some GDI handle wrappers to nint
Analyzers don't let you break the string into multiple lines due to lack of smarts in closing bracket spacing analyzer. :/
e5d24f6 to
8d015ae
Compare
dreddy-work
reviewed
Sep 24, 2021
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/ToolStripTemplateNode.cs
Show resolved
Hide resolved
dreddy-work
reviewed
Sep 24, 2021
dreddy-work
reviewed
Sep 24, 2021
dreddy-work
reviewed
Sep 24, 2021
RussKie
reviewed
Sep 27, 2021
Comment on lines
+23
to
+28
| #pragma warning disable IDE1006 // Naming Styles | ||
| internal nint _Result; | ||
| internal nint _LParam; | ||
| internal nint _WParam; | ||
| internal User32.WM _Msg; | ||
| #pragma warning restore IDE1006 // Naming Styles |
Contributor
There was a problem hiding this comment.
I really find this naming convention jarring and unsettling... Can we please have it as XxxInternal instead?
RussKie
added a commit
to RussKie/winforms
that referenced
this pull request
Sep 30, 2021
* Rename Message fields from '_Xyz' to 'XyzInternal` * Rename WINFORMSDEV0001 to WFDEV001 to align with existing diagnostic IDs
RussKie
added a commit
that referenced
this pull request
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store PARAM and result as nint and expose internally. Add DEBUG obsoletion to flush out any usages of the IntPtr properties (and suppress in consuming projects).
Note that the Message field names are deliberately named to match the properties for easier diffing in this PR.
Other changes:
Microsoft Reviewers: Open in CodeFlow