Conversation
* Rename Message fields from '_Xyz' to 'XyzInternal` * Rename WINFORMSDEV0001 to WFDEV001 to align with existing diagnostic IDs
18442d1 to
9460e31
Compare
| // The first thing the ime does on a key it cares about is send a VK_PROCESSKEY, so we use | ||
| // that to sling focus to the grid. | ||
| if (m._WParam == VK_PROCESSKEY) | ||
| if (m.WParamInternal == VK_PROCESSKEY) |
There was a problem hiding this comment.
tbh, i did not like this naming convention either. We use lParam and wParam extensively across VS and .NET repos. why are they not good here?
There was a problem hiding this comment.
Having LParam and lParam in the same codebase would be very confusing. I proposed LParamInternal as this a) would align with HandleInternal and b) clearly indicate the internal purpose.
There was a problem hiding this comment.
Having
LParamandlParamin the same codebase
Can you elaborate on what do you mean by same code base here? In case of HandleInternal we have a public property Handle in the same class.
There was a problem hiding this comment.
Message type has both public properties (e.g. LParam, etc.) and internal fields (e.g. _LParam, etc.). We are breaking our designer guidelines by exposing fields, which in this case can be justified, by doing so we need to fix the naming convention (LParamInternal instead _LParam), which is the intent of this PR.
Microsoft Reviewers: Open in CodeFlow