Fixing Domain/NumericUpDown AccessibleNames and navigation by vladimir-krestov · Pull Request #2382 · dotnet/winforms

vladimir-krestov · 2019-11-18T14:52:17Z

Fixes Screen reader announcement of numeric up-down and domain up-down controls reads as "Spinner spinner" #2370
Fixes Narrator does not announce Up/Down buttons when targeting .NET Core 5.0 #2406
Fixes ScreenReader navigation using CapsLock+arrows

Proposed changes

Add default AccessibleNames for Domain/NumericUpDown AccessibleObjects
Make code refactoring
Add unit tests
Implement UIA provider for UpDown control to fix ScreenReader navigation

Customer Impact

Changed default AccessibleNames that announced by Narrator
Fixed navigation regression Narrator does not announce Up/Down buttons when targeting .NET Core 5.0 #2406
Changed ScreenReader navigation using CapsLock+arrow combination

Regression?

Yes

Risk

Minimal

Screenshots

Before

Domain/NumericUpDown AccessibleObjects have "Spinner" default AccessibleNames
Narrator navigation using CapsLock+keyboard arrows:
1. Forward:
  Narrator skips an UpDown container and up/down buttons announcing an edit pane only
2. Backward:
  Narrator announces an edit pane and UpDown container but skips up/down buttons

After

Domain/NumericUpDown AccessibleObjects have correct default AccessibleNames
Narrator navigation using CapsLock+keyboard arrows:
Narrator announces all UpDown items according to an accessibility tree

Test methodology

Unit testing
CTI
Manual UI testing

Accessibility testing

Using Inspect and Narrator tools

Test environment(s)

SDK Version: 5.0.100-alpha1-015730
Microsoft Windows [Version 10.0.18363.418]

Microsoft Reviewers: Open in CodeFlow

codecov · 2019-11-18T15:12:11Z

Codecov Report

Merging #2382 into master will decrease coverage by 0.02321%.
The diff coverage is 5.55556%.

@@                Coverage Diff                 @@
##              master      #2382         +/-   ##
==================================================
- Coverage   29.22201%   29.1988%   -0.02321%     
==================================================
  Files           1003       1003                 
  Lines         259503     259610        +107     
  Branches       36836      36852         +16     
==================================================
- Hits           75832      75803         -29     
- Misses        178763     178901        +138     
+ Partials        4908       4906          -2

Flag	Coverage Δ
#Debug	`29.1988% <5.55556%> (-0.02322%)`	⬇️
#production	`29.1988% <5.55556%> (-0.02322%)`	⬇️
#test	`100% <ø> (ø)`	⬆️

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/DomainUpDownAccessibleObjectTests.cs

...System.Windows.Forms/tests/UnitTests/AccessibleObjects/NumericUpDownAccessibleObjectTests.cs

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/DomainUpDownAccessibleObjectTests.cs

vladimir-krestov · 2019-11-20T16:04:25Z

At the moment, I changed AccessibleNames for UpDown buttons to avoid Mas bugs:

vladimir-krestov · 2019-11-21T05:35:20Z

At the moment, Narrator doesn't announce UpDown buttons, separated #2406 Issue was created.
Also, Narrator jumps out from Domain/NumericUpDown if a user moves forward using CapsLock+righ arrow combination.
If to move backward Narrator announces Domain/NumericUpDown control and edit panel, but if to move forward Narrator announces edit panels only.
Please see gif:

.Net 4.8 works in a similar way.
@merriemcgaw, this is a bug or design decision?

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/DomainUpDownAccessibleObjectTests.cs

RussKie

LGTM, few stylistic comments

src/System.Windows.Forms/src/System/Windows/Forms/NumericUpDown.cs

src/System.Windows.Forms/src/System/Windows/Forms/DomainUpDown.cs

RussKie

👍

vladimir-krestov · 2019-11-28T06:54:53Z

In the last commits, I fixed ScreenReader navigation using CapsLock+keyboard arrow combination, please see gifs in the description.

vladimir-krestov · 2019-11-28T06:57:11Z

At the moment, I don't know why CI build fails. I'll check it as soon as possible.

PR dotnet#2382 Fixes dotnet#2370 Fixes dotnet#2406 Fixes ScreenReader navigation using CapsLock+arrows Added default names for UpDown containers Added default names for Up/Down button group Implemented UIA provider for Domain/NumericUpDown controls Implemented UIA provider for UpDownButtons group Added unit tests Made code refactoring

vladimir-krestov · 2019-11-29T13:53:37Z

Testers approved these changes ✔️

Fixes #4123 I tracked the current behavior to this PR: #2382 ## Proposed changes - DomainUpDown/NumericUpdown should return true when queried for IsKeyboardFocusablePropertyId and they are visible and enabled. This is the behavior of the base class, so we shouldn't override it here. ## Regression? - Yes. ## Risk - Someone might be relying on the current behavior. ## Test methodology  - Added new tests.

vladimir-krestov requested a review from a team as a code owner November 18, 2019 14:52

vladimir-krestov self-assigned this Nov 18, 2019

vladimir-krestov added waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) waiting-review This item is waiting on review by one or more members of team labels Nov 18, 2019

RussKie suggested changes Nov 20, 2019

View reviewed changes

ghost added the waiting-author-feedback The team requires more information from the author label Nov 20, 2019

RussKie removed the waiting-review This item is waiting on review by one or more members of team label Nov 20, 2019

ghost removed the waiting-author-feedback The team requires more information from the author label Nov 20, 2019

RussKie reviewed Nov 26, 2019

View reviewed changes

src/System.Windows.Forms/tests/UnitTests/AccessibleObjects/DomainUpDownAccessibleObjectTests.cs Outdated Show resolved Hide resolved

vladimir-krestov force-pushed the dev/v-vlkres/2370_Numeric_Domain_UpDown_AccName branch from aa280a4 to 1a614a2 Compare November 26, 2019 15:44

RussKie previously approved these changes Nov 27, 2019

View reviewed changes

src/System.Windows.Forms/src/System/Windows/Forms/NumericUpDown.cs Outdated Show resolved Hide resolved

src/System.Windows.Forms/src/System/Windows/Forms/DomainUpDown.cs Outdated Show resolved Hide resolved

vladimir-krestov dismissed RussKie’s stale review via 818e5fb November 27, 2019 09:43

RussKie reviewed Nov 27, 2019

View reviewed changes

vladimir-krestov changed the title ~~WIP: Fixing Domain/NumericUpDown AccessibleNames~~ WIP: Fixing Domain/NumericUpDown AccessibleNames and navigation Nov 28, 2019

vladimir-krestov force-pushed the dev/v-vlkres/2370_Numeric_Domain_UpDown_AccName branch from 818e5fb to ec860d0 Compare November 29, 2019 13:49

vladimir-krestov removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Nov 29, 2019

vladimir-krestov changed the title ~~WIP: Fixing Domain/NumericUpDown AccessibleNames and navigation~~ Fixing Domain/NumericUpDown AccessibleNames and navigation Nov 29, 2019

vladimir-krestov added the 📫 waiting-approval label Nov 29, 2019

RussKie removed the 📫 waiting-approval label Dec 1, 2019

RussKie approved these changes Dec 1, 2019

View reviewed changes

RussKie merged commit 5aeb34a into dotnet:master Dec 1, 2019

ghost added this to the 5.0 milestone Dec 1, 2019

M-Lipin mentioned this pull request Feb 18, 2020

AccessibleName default values for WinForms Controls #2870

Closed

albertvaka mentioned this pull request Oct 17, 2020

DomainUpDown/NumericUpdown should be KeyboardFocusable #4127

Merged

vladimir-krestov deleted the dev/v-vlkres/2370_Numeric_Domain_UpDown_AccName branch November 4, 2020 07:37

vladimir-krestov mentioned this pull request Aug 31, 2021

Epic - [Accessibility] Implement UIA provider for all controls #3421

Closed

70 tasks

ghost locked as resolved and limited conversation to collaborators Feb 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing Domain/NumericUpDown AccessibleNames and navigation#2382

Fixing Domain/NumericUpDown AccessibleNames and navigation#2382
RussKie merged 1 commit intodotnet:masterfrom
vladimir-krestov:dev/v-vlkres/2370_Numeric_Domain_UpDown_AccName

vladimir-krestov commented Nov 18, 2019 •

edited

Loading

Uh oh!

codecov bot commented Nov 18, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vladimir-krestov commented Nov 20, 2019

Uh oh!

vladimir-krestov commented Nov 21, 2019

Uh oh!

Uh oh!

RussKie left a comment

Uh oh!

Uh oh!

Uh oh!

RussKie left a comment

Uh oh!

vladimir-krestov commented Nov 28, 2019

Uh oh!

vladimir-krestov commented Nov 28, 2019

Uh oh!

vladimir-krestov commented Nov 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

vladimir-krestov commented Nov 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Screenshots

Before

After

Test methodology

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

codecov bot commented Nov 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vladimir-krestov commented Nov 20, 2019

Uh oh!

vladimir-krestov commented Nov 21, 2019

Uh oh!

Uh oh!

RussKie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RussKie left a comment

Choose a reason for hiding this comment

Uh oh!

vladimir-krestov commented Nov 28, 2019

Uh oh!

vladimir-krestov commented Nov 28, 2019

Uh oh!

vladimir-krestov commented Nov 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vladimir-krestov commented Nov 18, 2019 •

edited

Loading

codecov bot commented Nov 18, 2019 •

edited

Loading