DomainUpDown/NumericUpdown should be KeyboardFocusable#4127
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4127 +/- ##
====================================================
+ Coverage 68.12157% 98.11688% +29.99530%
====================================================
Files 1482 494 -988
Lines 508855 258454 -250401
Branches 41468 4489 -36979
====================================================
- Hits 346640 253587 -93053
+ Misses 155976 4105 -151871
+ Partials 6239 762 -5477
Flags with carried forward coverage won't be shown. Click here to find out more. |
RussKie
left a comment
There was a problem hiding this comment.
Looks sensible.
@vladimir-krestov was there a specific reason to set it to false initially?
|
@RussKie, actually, no. That is my mistake in #2382. But we can't set |
|
Please add unit tests. Thank you. |
|
@msftbot merge if @vladimir-krestov approves |
|
Hello @RussKie! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
The code is fine, I need to do some tests. |
|
All right! Thank you 😊 |
|
[Unrelated to this change] While testing this PR I found a small change was needed to the |
|
How did you install cmake?
We had observed issues with cmake that is shipped with VS, it is noted in the docs.
|
|
It's installed separately and I'm using the latest one. Maybe some versions of CMake accept an empty source dir and default to |
Fixes #4123
I tracked the current behavior to this PR: #2382
Proposed changes
Regression?
Risk
Test methodology
Microsoft Reviewers: Open in CodeFlow