Skip to content

Update NuGet#3252

Merged
dsplaisted merged 2 commits into
dotnet:masterfrom
dsplaisted:update-nuget
May 22, 2019
Merged

Update NuGet#3252
dsplaisted merged 2 commits into
dotnet:masterfrom
dsplaisted:update-nuget

Conversation

@dsplaisted

Copy link
Copy Markdown
Member

Replacement for #3243, on top of #3250 which should hopefully fix things.

@dsplaisted dsplaisted requested a review from a team May 21, 2019 21:11
@wli3

wli3 commented May 22, 2019

Copy link
Copy Markdown

GeneratePackageOnBuild=true on pack as tool is regressed. #2140

Caused by this https://github.com/NuGet/NuGet.Client/pull/2822/files

Thinking a solution...

cc @nkolev92

@wli3

wli3 commented May 22, 2019

Copy link
Copy Markdown

just reopened #2114

@dsplaisted

Copy link
Copy Markdown
Member Author

@wli3 @dotnet/dotnet-cli merging this without explicit signoff, it's a version update and a test skip which we discussed

@dsplaisted dsplaisted merged commit a67433f into dotnet:master May 22, 2019
dsplaisted pushed a commit to dsplaisted/sdk that referenced this pull request Feb 19, 2020
…021.1 (dotnet#3252)

- Microsoft.NETCore.Compilers - 3.4.0-beta3-19521-01
GangWang01 pushed a commit to GangWang01/sdk that referenced this pull request Jun 7, 2022
…otnet#3252)

enabled documentation for shipping assemblies and fixed all issues.
disabled CS1591 as still not all public members are documented
GangWang01 pushed a commit to GangWang01/sdk that referenced this pull request Jun 21, 2022
…otnet#3252)

enabled documentation for shipping assemblies and fixed all issues.
disabled CS1591 as still not all public members are documented
GangWang01 pushed a commit to GangWang01/sdk that referenced this pull request Jul 11, 2022
…otnet#3252)

enabled documentation for shipping assemblies and fixed all issues.
disabled CS1591 as still not all public members are documented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants