Run target according to NoBuild flag#2140
Merged
Merged
Conversation
wli3
commented
Apr 12, 2018
| <!-- Ensure there is minimal verbosity output pointing to the publish directory and not just the | ||
| build step's minimal output. Otherwise there is no indication at minimal verbosity of where | ||
| the published assets were copied. --> | ||
| Condition="$(IsPublishable) == 'true' and '$(NoBuild)' != 'true'" |
Author
There was a problem hiding this comment.
@nguerrera Only add an extra condition is added based on the "WIP" and let PackTool depends on both of them. But only one of them will be run according to the flag at that time
Contributor
There was a problem hiding this comment.
I don't really understand what you wrote here. We can't condition Publish on NoBuild because we need /t:Publish /p:NoBuild=true to work. I think you're acknowledging that and that this isn't final, but I'm not entirely sure. ;)
Author
There was a problem hiding this comment.
Ah... you are right. I still need a target to "re direct"
nguerrera
reviewed
Apr 12, 2018
| </_CorePublishTargets> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="PublishBuild" |
Contributor
There was a problem hiding this comment.
These should be _ ("private") and still thinking about the names.
Author
There was a problem hiding this comment.
_PublishBuildAlternative _PublishNoBuildAlternative ?? So people look at the following line will know only one of them will be run. And by appending alternative, it looks pretty internal
<Target Name="Publish"
Condition="$(IsPublishable) == 'true'"
DependsOnTargets="$(_PublishBuildAlternative);$(_PublishNoBuildAlternative)"
Author
|
@nguerrera added test, and ready |
nguerrera
reviewed
Apr 13, 2018
| { | ||
| public class GivenThatWeWantToPackAToolProjectWithGeneratePackageOnBuild : SdkTest | ||
| { | ||
|
|
nguerrera
approved these changes
Apr 13, 2018
nguerrera
reviewed
Apr 13, 2018
|
|
||
| result.StdOut.Should().NotContain("There is a circular dependency"); | ||
| result.ExitCode.Should().Be(0); | ||
|
|
nguerrera
reviewed
Apr 13, 2018
| CommandResult result = buildCommand.Execute(); | ||
|
|
||
| result.StdOut.Should().NotContain("There is a circular dependency"); | ||
| result.ExitCode.Should().Be(0); |
Contributor
There was a problem hiding this comment.
This is written elsewhere as Should().Pass().And.NotHaveStdOutContaining("...");
NuGet will set No Build flag in their target to avoid circular dependency. However, Publish evulate NoBuild during evaluation time.
livarcocc
added a commit
that referenced
this pull request
Apr 16, 2018
* master: (26 commits) Honor NoBuild flag in target (#2140) Support uppercase 'V' in TargetFrameworkVersion Prevent test MSBuild nodes from persisting LOC CHECKIN | dotnet/sdk master | 20180409 (#2120) Update expected NETStandard.Library package version Update Stage 0 .NET CLI and sync NuGet version Disable multilevel lookup in more cases when running tests Add support for InvariantGlobalization MSBuild property Don't include .resx files in None item Enable nupkg signing Don't include files with source extension in None item by default Fixing a grammar issue Add support for /t:Publish /p:NoBuild=true Feedback Pin the FSharp.Core package version Fix F# typo, add smoke tests, Fix behaviour for implicit defines Adding satellite assembly tests for transitive direct references Responding to PR feedback. Adding some basic tests ensuring direct references are transitive Updating GenerateDepsFile so that direct references of referenced projects appear in the deps.json ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2114