Remove transitive dependencies for System.Private.Uri (#25420)#26448
Merged
Conversation
joeloff
approved these changes
Jul 6, 2022
Forgind
pushed a commit
to dotnet/msbuild
that referenced
this pull request
Jul 20, 2022
System.Private.Uri 6.0.0 is reported as a prebuilt in source-build due to these references. This fix is similar to dotnet/sdk#26448. I tested this change in a source-build tarball context and verified the prebuilt package is no longer getting pulled. I also made sure msbuild builds with ./build.sh. I noticed that these were introduced due to some CG concerns (20cdf6f), so the references were conditioned out for source-build instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick the changes from #25420 (release/6.0.1xx) that never got merged into main.