Remove references to System.Private.Uri#7822
Conversation
|
CG issues only show up when you try to insert MSBuild into VS, correct? Would you mind merging these changes into a branch (on dotnet/msbuild) prefixed with |
|
Yes, let's condition. The references are useless but required, a fun position to be in! @Forgind, CG alerts are generated in official builds on certain branches only because of configuration we don't control so there's no good way to test; an exp branch doesn't do it as I learned to my chagrin a while ago. |
Forgind
left a comment
There was a problem hiding this comment.
You don't need System.Runtime either? I'm surprised, but the source build leg seems to have passed...
The source-build leg might not have caught if this reference was needed, but I verified locally that removing both references doesn't cause any problems in a full end-to-end build. As well as gets rid of the System.Private.Uri prebuilt package. |
|
As before, please merge when appropriate, I don't have permissions. |
System.Private.Uri 6.0.0 is reported as a prebuilt in source-build due to these references. This fix is similar to dotnet/sdk#26448.
I tested this change in a source-build tarball context and verified the prebuilt package is no longer getting pulled. I also made sure msbuild builds with
./build.sh.I noticed that these were introduced due to some CG concerns (20cdf6f), so if this change causes issues for the MSBuild build, then these System.Private.Uri and System.Runtime references can be conditioned out for source-build instead.