Skip to content

Check that SDK and app archs match before setting DOTNET_ROOT when using dotnet run#19860

Merged
mateoatr merged 9 commits intodotnet:mainfrom
mateoatr:checkArchDotNetRoot
Aug 24, 2021
Merged

Check that SDK and app archs match before setting DOTNET_ROOT when using dotnet run#19860
mateoatr merged 9 commits intodotnet:mainfrom
mateoatr:checkArchDotNetRoot

Conversation

@mateoatr
Copy link
Contributor

@mateoatr mateoatr commented Aug 18, 2021

Fixes #19743. I tested this locally. The steps for reproing the fix are already in the above issue. For checking the app's architecture, this first checks for the RuntimeIdentifier property of the project to run, if not set, it'll grab the architecture from the DefaultAppHostRuntimeIdentifier prop.

@ghost ghost added the Area-External label Aug 18, 2021
vitek-karas
vitek-karas reviewed Aug 19, 2021
View reviewed changes
vitek-karas
vitek-karas approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - please wait for SDK owners to also review this.

Remove spaces in prop
4d313d9 
Allow test asset copy
richlander
richlander reviewed Aug 19, 2021
View reviewed changes
@richlander
Copy link
Member

richlander commented Aug 19, 2021

Can/will enthusiastically test this as soon as there is a build.

@mateoatr mateoatr merged commit 36e9be0 into dotnet:main Aug 24, 2021
This was referenced Aug 24, 2021
Closed
Merged
agocke added a commit that referenced this pull request Aug 31, 2021
@agocke @mateoatr
Check that SDK and app archs match before setting DOTNET_ROOT when …
4114ca1 
…using `dotnet run` (#19860) (#20102)

Check that dotnet arch and app's arch match before setting DOTNET_ROOT

(cherry picked from commit 36e9be0)

Co-authored-by: Mateo Torres-Ruiz <mateoatr@users.noreply.github.com>
@ericstj ericstj mentioned this pull request Oct 25, 2021
Open
@Algorithman
Copy link

Algorithman commented Dec 13, 2021

Question: Is this already in the release/when will this be in the installer?

@vitek-karas
Copy link
Member

vitek-karas commented Dec 13, 2021

This fix is in .NET 6 GA - so if you download the final release of .NET 6, it should be there.

@Algorithman
Copy link

Algorithman commented Dec 13, 2021

Thx. Correct if i'm wrong, i need to uninstall .net5 then?

@vitek-karas
Copy link
Member

vitek-karas commented Dec 13, 2021

You should not need to uninstall .NET 5. The SDKs are side by side - so both can be installed. By default commands like dotnet run should pick the latest version (so if you have .NET6 it should use .NET 6). Unless you're using global.json files which can specify exact SDK version to use.

You can try this by running dotnet --info from the directory where you would run dotnet run. It should print out something like:

.NET SDK (reflecting any global.json):
 Version:   6.0.200-preview.21573.3
 Commit:    a2bb0dde82

Which will contain the exact SDK version used by the command (and dotnet run should use the same version).

@tmat tmat mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richlander richlander richlander left review comments

@vitek-karas vitek-karas vitek-karas approved these changes

+1 more reviewer

@sfoslund sfoslund sfoslund approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-External Team:Runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preview 7 UX for Arm64/x64 co-existence on macOS

5 participants

@mateoatr @richlander @Algorithman @vitek-karas @sfoslund