[release/6.0.1xx] Arch-independent support for dotnet run#20102
Merged
agocke merged 1 commit intodotnet:release/6.0.1xxfrom Aug 31, 2021
Merged
[release/6.0.1xx] Arch-independent support for dotnet run#20102agocke merged 1 commit intodotnet:release/6.0.1xxfrom
dotnet run#20102agocke merged 1 commit intodotnet:release/6.0.1xxfrom
Conversation
…using `dotnet run` (dotnet#19860) * Check that dotnet arch and app's arch match before setting DOTNET_ROOT * Check RuntimeIdentifier prop * Use new DOTNET_ROOT format Update tests * Remove spaces in prop Allow test asset copy * Update test * Update how we retrieve enum value name Keep behavior if there is no host to retrieve target arch from * Update Program.cs * Use ToUpperInvariant * Set ProcessArchitecture as targetArchitecture might be null (cherry picked from commit 36e9be0)
mateoatr
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #19860
Description
dotnet runsets DOTNET_ROOT, but it needs to pick the appropriate location based on the target architectureTesting
Unit tests, manual verification
Risk
Low