Skip to content

Add support for reading runtime capability#18214

Merged
pranavkm merged 4 commits intomainfrom
prkrishn/applycapability
Jun 23, 2021
Merged

Add support for reading runtime capability#18214
pranavkm merged 4 commits intomainfrom
prkrishn/applycapability

Conversation

@pranavkm
Copy link
Copy Markdown
Contributor

@pranavkm pranavkm commented Jun 10, 2021

@ghost
Copy link
Copy Markdown

ghost commented Jun 10, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@pranavkm pranavkm force-pushed the prkrishn/applycapability branch from 72878fe to ddfab9e Compare June 11, 2021 23:01
@pranavkm pranavkm force-pushed the prkrishn/applycapability branch from ddfab9e to 0254f6d Compare June 18, 2021 20:39
@pranavkm pranavkm marked this pull request as ready for review June 18, 2021 20:42
@pranavkm pranavkm requested a review from captainsafia June 18, 2021 20:42
reporter.Verbose("Reading hot reload capabilities failed. Using default capabilities.");
reporter.Verbose(ex.ToString());

return ImmutableArray.Create("Baseline", "AddDefinitionToExistingType", "NewTypeDefinition");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this doing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the compiler expects some baseline capabilities. These were what we previously had here, so I'm just returning them in case we can't get it from the app.

@pranavkm pranavkm enabled auto-merge (squash) June 23, 2021 15:25
@pranavkm pranavkm merged commit c9b61b1 into main Jun 23, 2021
@pranavkm pranavkm deleted the prkrishn/applycapability branch August 31, 2021 19:41
v-wuzhai pushed a commit that referenced this pull request Apr 22, 2024
Enable Windows Build in the VMR
ViktorHofer added a commit that referenced this pull request May 7, 2024
Enable Windows Build in the VMR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dotnet-watch] Watch needs to implement GetCapabilitiesAsync by probing the app

3 participants