-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[dotnet-watch] Watch needs to implement GetCapabilitiesAsync by probing the app #33402
Copy link
Copy link
Closed
dotnet/sdk
#18214Labels
DoneThis issue has been fixedThis issue has been fixedarea-commandlinetoolsIncludes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPIIncludes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPIenhancementThis issue represents an ask for new feature or an enhancement to an existing oneThis issue represents an ask for new feature or an enhancement to an existing onefeature-hot-reloadThis issue is related to the Hot Reload feaatureThis issue is related to the Hot Reload feaature
Milestone
Metadata
Metadata
Assignees
Labels
DoneThis issue has been fixedThis issue has been fixedarea-commandlinetoolsIncludes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPIIncludes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPIenhancementThis issue represents an ask for new feature or an enhancement to an existing oneThis issue represents an ask for new feature or an enhancement to an existing onefeature-hot-reloadThis issue is related to the Hot Reload feaatureThis issue is related to the Hot Reload feaature
Type
Fields
Give feedbackNo fields configured for issues without a type.
Currently,
WatchHotReloadServicehardcodes a list of capabilities in it's implementation: https://github.com/dotnet/roslyn/blob/4458d002fe24f68bc66e961d807c7569aa99d9f8/src/Features/Core/Portable/ExternalAccess/Watch/Api/WatchHotReloadService.cs#L31-L32. This needs to be replaced by a value provided by the runtime: https://github.com/dotnet/runtime/blob/main/src/coreclr/System.Private.CoreLib/src/System/Reflection/Metadata/AssemblyExtensions.cs#L85-L88.AssemblyExtensions.GetApplyUpdateCapabilitiesto watch.WatchHotReloadService