Skip to content

[dotnet-watch] Watch needs to implement GetCapabilitiesAsync by probing the app #33402

@pranavkm

Description

@pranavkm

Currently, WatchHotReloadService hardcodes a list of capabilities in it's implementation: https://github.com/dotnet/roslyn/blob/4458d002fe24f68bc66e961d807c7569aa99d9f8/src/Features/Core/Portable/ExternalAccess/Watch/Api/WatchHotReloadService.cs#L31-L32. This needs to be replaced by a value provided by the runtime: https://github.com/dotnet/runtime/blob/main/src/coreclr/System.Private.CoreLib/src/System/Reflection/Metadata/AssemblyExtensions.cs#L85-L88.

  • The agent (injected component) can query the runtime and return the value of AssemblyExtensions.GetApplyUpdateCapabilities to watch.
  • Watch would have some API to return this result to WatchHotReloadService

Metadata

Metadata

Assignees

Labels

DoneThis issue has been fixedarea-commandlinetoolsIncludes: Command line tools, dotnet-dev-certs, dotnet-user-jwts, and OpenAPIenhancementThis issue represents an ask for new feature or an enhancement to an existing onefeature-hot-reloadThis issue is related to the Hot Reload feaature

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions