[mono][debugger] Fix decode_value_compute_size #97418
Conversation
…t to keep it correct.
|
Tagging subscribers to this area: @thaystg Issue DetailsThis is necessary to compute the size of the valuetype before memcpy values to the memory.
|
lambdageek
left a comment
There was a problem hiding this comment.
native code lgtm, except there's some extra indentation
|
@ilonatommy could you take a look at the debug proxy |
|
does this need to be backported? |
Yes. I will do it. |
|
/backport to release/8.0-staging |
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/7645765328 |
|
@thaystg backporting to release/8.0-staging failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix 8653 xamarin
Applying: Fixing the order of the code, it doesn't matter in this case, but just to keep it correct.
Applying: Fix compilation
Applying: Fix debug fixed array on wasm debugger.
error: sha1 information is lacking or useless (src/mono/mono/component/debugger-agent.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 Fix debug fixed array on wasm debugger.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@thaystg an error occurred while backporting to release/8.0-staging, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
Implement decode_fixed_size_array_compute_size_internal
We were skipping this kind of field while was computing the size and this was causing a weird behavior because we were reading wrong information from the buffer.
Fix decode_value_compute_size it was decoding the buffer wrongly.
Improve wasm debugger - support inspect fixed size array (necessary to add a unit test).
Fixes dotnet/android#8653