[release/8.0-staging][mono][debugger] Fix decode_value_compute_size #97568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue Detailsnull
|
lambdageek
approved these changes
Jan 26, 2024
radical
reviewed
Jan 26, 2024
Comment on lines
+93
to
+96
| for (int i = 0; i < arraySize; i++) | ||
| { | ||
| inlineArray.Add(await sdbAgent.ValueCreator.CreateFixedArrayElement(cmdReader, elementType, $"{i}", token)); | ||
| } |
Member
There was a problem hiding this comment.
nit: this could probably be a method that takes in the type details, and the array size to return inlineArray, avoiding the multiple the awaits too.
| } | ||
| else | ||
| { | ||
| cmdReader.BaseStream.Position-=sizeof(byte); |
Member
There was a problem hiding this comment.
Suggested change
| cmdReader.BaseStream.Position-=sizeof(byte); | |
| cmdReader.BaseStream.Position -= sizeof(byte); |
| subtype: length.Rank == 1 ? "array" : null); | ||
| } | ||
|
|
||
| public async Task<JObject> CreateFixedArrayElement(MonoBinaryReader retDebuggerCmdReader, ElementType etype, string name, CancellationToken token) |
Member
There was a problem hiding this comment.
This seems very similar to ReadAsVariableValue. Maybe the core of that method can be extracted (to skip the reading from the retDebuggerCmdReader) - and that method can be used by ReadAsVariableValue and CreateFixedArrayElement.
| ElementType etype = (ElementType)cmdReader.ReadByte(); | ||
| if (etype == (ElementType)ValueTypeId.FixedArray && writableFields.Count() == 1) | ||
| { | ||
| ElementType elementType = (ElementType)cmdReader.ReadByte(); |
jeffschwMSFT
approved these changes
Jan 31, 2024
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 8.0.x
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #97418 to release/8.0-staging
/cc @thaystg
Customer Impact
dotnet/android#8653
Avoid assertion on runtime while debugging.
Fix debugger experience when it's trying to evaluate an expression that has a value type with an object inside it like this:
Regression
This was introduced in this PR: #76332
Testing
Manually tested.
Also added a test case.
Risk
Medium risk, only reading the debugger buffer correctly.