Add Separate Mode to XUnitLogChecker Where Only Dumps are Analyzed #94094
Conversation
the libraries tests.
new flagged command-line arguments, when calling the XUnitLogChecker.
|
Tagging subscribers to this area: @hoyosjs Issue DetailsIn issue #93988, we described a new requirement for the XUnitLogChecker, which is to be able to only run the dumps checking stage without looking into test logs. This requirement came to be from the Merge-on-Green initiative to improve our testing infrastructure in general. While CoreCLR testing uses the whole log checker, libraries testing will only need to use the dumps analyzer. This PR overhauls as necessary to add this possibility. Additionally, as part of this effort, this PR also adds actual command-line flags to the XUnitLogChecker, rather than relying on argument positioning. This will certainly make it more robust and easier to use in other places in the future.
|
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
carlossanlop
left a comment
There was a problem hiding this comment.
Left a couple comments for you to consider.
| System.Globalization.CultureInfo.InvariantCulture | ||
| ); | ||
|
|
||
| dumpsFound = Directory |
There was a problem hiding this comment.
Should we report and / or delete the obsolete dumps or do we know that the OS or Helix infra deals with that somehow?
…otnet#94094) * Overhauled the XUnitLogChecker to be able to work without a log for the libraries tests. * Adjusted the Helix script in helixpublishwitharcade.proj to use the new flagged command-line arguments, when calling the XUnitLogChecker.
In issue #93988, we described a new requirement for the XUnitLogChecker, which is to be able to only run the dumps checking stage without looking into test logs. This requirement came to be from the Merge-on-Green initiative to improve our testing infrastructure in general. While CoreCLR testing uses the whole log checker, libraries testing will only need to use the dumps analyzer. This PR overhauls as necessary to add this possibility.
Additionally, as part of this effort, this PR also adds actual command-line flags to the XUnitLogChecker, rather than relying on argument positioning. This will certainly make it more robust and easier to use in other places in the future.