[wasm] Disable runtime test failing due to stack overflow #69863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`JIT/Directed/tailcall/tailcall/tailcall.sh` Issue: dotnet#69517
4 tasks
lewing
approved these changes
May 26, 2022
Member
Author
|
This should be backported to preview5 too. |
Member
Author
|
/backport release/7.0-preview5 |
Member
Author
|
/backport to release/7.0-preview5 |
Contributor
|
Started backporting to release/7.0-preview5: https://github.com/dotnet/runtime/actions/runs/2399196476 |
Contributor
|
@radical an error occurred while backporting to release/7.0-preview5, please check the run log for details! Error: @radical is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your Microsoft team membership visibility is set to Public on https://github.com/orgs/microsoft/people?query=radical |
radical
added a commit
to radical/runtime
that referenced
this pull request
May 27, 2022
* [wasm] Disable runtime test failing due to stack overflow `JIT/Directed/tailcall/tailcall/tailcall.sh` Issue: dotnet#69517 * Also disable JIT/Directed/IL/Tailcall/ExplicitTailCallNoSO/ExplicitTailCallNoSO.sh * try to fix the exclusion * Fix path for exclusion
radical
added a commit
to radical/runtime
that referenced
this pull request
May 31, 2022
…tnet#69863)" This reverts commit 61441fa.
radical
added a commit
that referenced
this pull request
Jun 1, 2022
…70050) * [wasm] Fix runtime test failing due to the app running in debug mode Fixes #69517 - Recent [wasm-app-host commit](6b3ea40) changed `WasmApp.targets` so `WasmDebugLevel` would be set to enable debugging if `Configuration==Debug`. - this broke some runtime tests which depend on tail call optimizations, which get disabled when debugging is enabled in the runtime. - And the wasm apps for the runtime tests are being built with no configuration set, which defaults to `Debug`. Instead, propogate the config for the build to the wasm proxy (`WasmTestRunner`) projects too. Fixes #69517 . * Revert "[wasm] Disable runtime test failing due to stack overflow (#69863)" This reverts commit 61441fa.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIT/Directed/tailcall/tailcall/tailcall.shIssue: #69517
Fixes: #69850