[wasm] Fix runtime test failing due to the app running in debug mode #70050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#69517 - Recent [wasm-app-host commit](6b3ea40) changed `WasmApp.targets` so `WasmDebugLevel` would be set to enable debugging if `Configuration==Debug`. - this broke some runtime tests which depend on tail call optimizations, which get disabled when debugging is enabled in the runtime. - And the wasm apps for the runtime tests are being built with no configuration set, which defaults to `Debug`. Instead, propogate the config for the build to the wasm proxy (`WasmTestRunner`) projects too. Fixes dotnet#69517 .
…tnet#69863)" This reverts commit 61441fa.
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsFixes #69517
Fixes #69517 .
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69517
Recent wasm-app-host commit changed
WasmApp.targetssoWasmDebugLevelwould be set to enable debugging ifConfiguration==Debug.optimizations, which get disabled when debugging is enabled in the
runtime.
And the wasm apps for the runtime tests are being built with no
configuration set, which defaults to
Debug. Instead, propogate theconfig for the build to the wasm proxy (
WasmTestRunner) projects too.