Add SslApplicationProtocol.Http3#56775
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFix #1293
|
| // Refer to IANA on ApplicationProtocols: https://www.iana.org/assignments/tls-extensiontype-values/tls-extensiontype-values.xhtml#alpn-protocol-ids | ||
| // h2 | ||
| /// <summary>Defines a <see cref="SslApplicationProtocol"/> instance for HTTP 3.0.</summary> | ||
| public static readonly SslApplicationProtocol Http3 = new SslApplicationProtocol(s_http3Utf8, copy: false); |
There was a problem hiding this comment.
ATM, we don't do that for HttpVersion.Http3 since you can easily construct the version manually and this is very similar.
Either way, if we decide to annotate this, we should be consistent and do the same thing with Http3 version.
ManickaP
left a comment
There was a problem hiding this comment.
There are also places in the loopback server and h/3 tests where "h3" is used and should be replaced as well.
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs
Outdated
Show resolved
Hide resolved
Should |
Since it's only in tests, it doesn't matter that much. You could also change the type from |
ManickaP
left a comment
There was a problem hiding this comment.
Thanks for the contribution, LGTM.
Fix #1293