Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue Details#56775 broke HttpStress. Instead of including
|
wfurt
approved these changes
Aug 5, 2021
Member
wfurt
left a comment
There was a problem hiding this comment.
This will probably eventually work but looks ok for now.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ManickaP
approved these changes
Aug 5, 2021
Contributor
Author
@wfurt you mean eventually this will stop working? If yes why? |
Member
|
No, this will always work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#56775 broke HttpStress.
Instead of including
System.Net.Security, I'm reverting this to the old stringly-typed code, so it keeps building with official preview SDK-s, not only docker / locally-built one.