Logging Generator: messaging fix#54080
Merged
maryamariyan merged 2 commits intodotnet:mainfrom Jun 14, 2021
Merged
Conversation
(Current) Actual Template [foo, foo] is not provided as argument to the logging method (To be) Expected Template 'foo' is not provided as argument to the logging method
Template name was not being passed to the diag method as expected, causing the message to contain a key/value pair instead of template name. Also updated the Strings to add quotes around the template name to make TemplateHasNoCorrespondingArgumentMessage consistent with ArgumentHasNoCorrespondingTemplateMessage. Fixes dotnet#54008
|
Tagging subscribers to this area: @maryamariyan Issue DetailsUpdate TemplateHasNoCorrespondingArgument diag message to contain Template name instead of key value pair. Also updated String Resources to add quotes around the template name to be consistent with ArgumentHasNoCorrespondingTemplateMessage. Updated test case to check for diag message contents. Fixes #54008
|
|
|
Closed
maryamariyan
approved these changes
Jun 12, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update TemplateHasNoCorrespondingArgument diag message to contain Template name instead of key value pair. Also updated String Resources to add quotes around the template name to be consistent with ArgumentHasNoCorrespondingTemplateMessage. Updated test case to check for diag message contents.
Fixes #54008