Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

All CLA requirements met.

Just added the test

Just updated the test

I have tried sifting through the 3 failing tests but I can't tell where the problem is. Any Pointers @maryamariyan

What I found:

System.Numerics.Tests.GenericVectorTests.SumDouble [FAIL]
      System.NullReferenceException : Object reference not set to an instance of an object.
      Stack Trace:
        /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs(3176,0): at System.Numerics.Tests.GenericVectorTests.TestSum[T](Func`2 expected)
        /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs(3152,0): at System.Numerics.Tests.GenericVectorTests.SumDouble()
    System.Numerics.Tests.GenericVectorTests.SumSingle [FAIL]
      System.NullReferenceException : Object reference not set to an instance of an object.
      Stack Trace:
        /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs(3176,0): at System.Numerics.Tests.GenericVectorTests.TestSum[T](Func`2 expected)
        /_/src/libraries/System.Numerics.Vectors/tests/GenericVectorTests.cs(3149,0): at System.Numerics.Tests.GenericVectorTests.SumSingle()

The test failures are unrelated to your changes and are addressed in #54119

I noticed you added one commit per *.xlf file. When you build the gen\Microsoft.Extensions.Logging.Generators.csproj project, it automatically updated the xlf files for you.

Oh I presumed I had to had code, I can undo all the commits

Oh I presumed I had to had code, I can undo all the commits

no need to undo.

ok thanks for the clarification

just wanted to make sure you've tried building locally as well

Thank you both @jeffl8n and @j0nimost for your contribution PRs (#54080 and #54058) to this repo.
The two PRs are fixing the same issue and with similar diff, I approved both.

I'll merged PR #54080 since it was finalized first.

@j0nimost look forward to more contributions in the future :)

Thank you @maryamariyan

Sorry for the redundancy @j0nimost. I missed where you had already started a fix/PR for it when I submitted mine.