[cdac-build-tool] don't embed resources #108293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around dotnet/msbuild#9152 Possibly fixes dotnet#107936
it's run once, in-tree, during the coreclr build. there is no need to embed files that are in the same repo checkout.
Member
Author
|
This is a better fix than #108289, but I'm not comfortable backporting it to .NET 9 |
jkoritzinsky
approved these changes
Sep 26, 2024
steveisok
approved these changes
Sep 26, 2024
Contributor
|
Tagging subscribers to this area: @tommcdon |
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
reviously we used EmbeddedResource to collect the contract descriptor baselines into cdac-build-tool and we also embedded the C source template. But we only ever run cdac-build-tool during the runtime build - the files are in the same source tree. Just pass their paths when invoking the tool, don't embed them. Fixes dotnet#107958 * don't embed baselines into cdac-build-tool * don't embed the template source file in the tool
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used
EmbeddedResourceto collect the contract descriptor baselines intocdac-build-tooland we also embedded the C source template.But we only ever run
cdac-build-toolduring the runtime build - the files are in the same source tree. Just pass their paths when invoking the tool, don't embed them.Fixes #107958