Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: abb7df5
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ef49cd0
Choose a head ref
  • 16 commits
  • 121 files changed
  • 15 contributors

Commits on Jan 6, 2022

  1. [wasm][debugger] GetProperties broken on chrome (#63403)

    * Fixing how we test and the implementation after #62627
    
    * Passing null to name.
    thaystg authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    7fc4b6a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a0f438 View commit details
    Browse the repository at this point in the history
  3. [wasm] Fix test filtering for debugger tests on windows (#63380)

    This caused the disabled ArrayTests to run on windows, causing the builds to fail. With this change, the tests should correctly get skipped on windows.
    radical authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    634dfa1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44b9a6e View commit details
    Browse the repository at this point in the history
  5. Fix time reporting for the merged tests (#63452)

    In XUnitWrapperGenerator we need to initialize the stopwatch
    variable using Stopwatch.StartNew(), not just new Stopwatch(),
    otherwise the stopwatch never starts to run, that's why all the
    test case times showed as zero. (Alternatively we could use
    new Stopwatch() followed by stopwatch.Start() but I believe that
    Stopwatch.StartNew() is generally considered to be more
    performant.)
    
    After applying this fix, some short test times started reporting
    their running time in scientific notation (e.g. 5.5e-5) so I
    modified the formatting to F6 - in the Methodical suite I see
    a test running for 55 microseconds.
    
    Thanks
    
    Tomas
    trylek authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    599ab0e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0b7bef0 View commit details
    Browse the repository at this point in the history
  7. Ensure UserSecretsIdAttribute is added to assembly (#63415)

    When Microsoft.Extensions.Configuration.UserSecrets is referenced transitively, for example through Extensions.Hosting, the UserSecretsIdAttribute isn't getting added to the built assembly. This is because the logic is contained in a `build` folder which is excluded by the dependency from Extensions.Hosting.
    
    The fix is to move the logic to `buildTransitive`, so it gets picked up by NuGet. One wrinkle is that the logic now conflicts with the netstandard compatibility logic added by the library infrastructure. In order to make progress, disable that logic for this package and rely on its dependencies to raise the compat error.
    
    Contributes to #63246
    eerhardt authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    392b35c View commit details
    Browse the repository at this point in the history
  8. Fix stack overflow with X509Certificate FriendlyName

    A FriendlyName in Windows' length is a DWORD, an unsigned integer. We
    however marshal it as a signed integer, so a friendly name with a
    length greater than int.MaxValue would wrap around to negative. This
    in turn would be "below" the stackalloc threshold, and attempt to stackalloc
    a negative value. stackalloc treats this value as unsigned, so it results
    in allocating too much on the stack.
    vcsjones authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d988a52 View commit details
    Browse the repository at this point in the history
  9. [mono] Reorganize zlib dependency logic (#63365)

    * [mono] Add back HAVE_SYS_ZLIB support
    
    In particular this re-enables embedded PDB support on iOS and Android
    
    * [mono] Reorganize zlib dependency logic
    
    Instead of deciding whether features are enabled based on the presence or
    absense of zlib, add switches to control features (embedded PDB support, and
    compressed log profiler output) and based on that require zlib.
    
    On some platforms we use the in-tree copy of zlib from
    src/native/external/zlib, otherwise we want to link against the system zlib.
    
    Previously, if zlib was missing the build would quietly succeed, but the
    feature support would be missing.  Now, if the feature isn't disabled but zlib
    is missing, we fail the build.
    
    If both features are disabled, don't depend on zlib at all.
    
    * Fix typos
    
    Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
    
    * Style nits
    
    - reverse if() logic to avoid negation
    
    - use cmakedefine without a value in config.h.in, same as CoreCLR
    
    Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
    lambdageek and am11 authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    0e800a6 View commit details
    Browse the repository at this point in the history
  10. Convert JIT/Methodical/Array/range Pri0 tests and hook up mobile test…

    …ing (#62752)
    
    Co-authored-by: Tomas <trylek@microsoft.com>
    jkoritzinsky and trylek authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    90ec876 View commit details
    Browse the repository at this point in the history
  11. Fix bugs with generation for ctor param default values (#62798)

    * Fix bugs with generation for ctor param default values
    
    * Address review feedback
    
    * Address feedback
    layomia authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    98c5328 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    b0685e1 View commit details
    Browse the repository at this point in the history
  13. [mono] Make some icalls pass/return object references using ObjectHan…

    …dleOnStack/QCallTypeHandle (#62141)
    
    * [mono] Make some icalls return objects using an extra ObjectHandleOnStack argument.
    
    * Fix the passing of scalar vtypes on wasm.
    
    * Convert RuntimeTypeHandle icalls to receive a QCallTypeHandle.
    
    Also do some other cleanups:
    * Convert some icalls which don't receive/return objects any more and don't
      return an error to NOHANDLES.
    * Implement IsGenericVariable in managed code.
    * Add a separate GetMetadataToken icall to avoid the REUSE_WRAPPER stuff.
    * Sync the implementation of IsTypeDefinition with coreclr.
    
    * Convert some RuntimeType icalls to use QCallTypeHandles/ObjectHandleOnStack.
    
    * Fix RuntimeType.GetPacking () to work with dynamic types.
    
    * Convert internal_from_name to use QCallTypeHandles/ObjectHandleOnStack.
    
    * Convert more icalls.
    
    * Update src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/QCallHandles.cs
    
    Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
    
    * Remove unused argument from RuntimeTypeHandle:internal_from_name ().
    
    * Add support for FRAME_TYPE_IL_STATE to the metadata stack walker code.
    
    * Update coding style in QCallTypeHandle:.ctor ().
    
    * Revert "Convert more icalls."
    
    * Convert some Delegate icalls.
    
    * Convert some Enum icalls.
    
    * Convert some Marshal icalls.
    
    * Avoid creating RuntimeType objects while AOTing.
    
    * Convert some RuntimeType icalls.
    
    Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
    vargaz and lambdageek authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    01cc900 View commit details
    Browse the repository at this point in the history
  14. [DRAFT][Perf][Mono] Enable llvm for arm perf runs (#63311)

    Enable llvm for arm perf runs.
    Nathan Ricci authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    5993a3a View commit details
    Browse the repository at this point in the history
  15. JIT: save generics context for late devirtualization (#63420)

    If we have a non-inline candidate call with generics context, save
    the context so it's available for late devirtualization.
    
    Fixes a missing devirtualization reported in #63283.
    
    I am deliberately leaving `LateDevirtualizationInfo` more general than
    necessary as it may serve as a jumping-off point for enabling late
    inlining.
    AndyAyersMS authored Jan 6, 2022
    Configuration menu
    Copy the full SHA
    a0220fd View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. [Revert] Reverted change to global build job (#63483)

    Nathan Ricci authored Jan 7, 2022
    Configuration menu
    Copy the full SHA
    ef49cd0 View commit details
    Browse the repository at this point in the history
Loading