-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Comparing changes
Open a pull request
base repository: dotnet/runtime
base: abb7df5
head repository: dotnet/runtime
compare: ef49cd0
- 16 commits
- 121 files changed
- 15 contributors
Commits on Jan 6, 2022
-
[wasm][debugger] GetProperties broken on chrome (#63403)
* Fixing how we test and the implementation after #62627 * Passing null to name.
Configuration menu - View commit details
-
Copy full SHA for 7fc4b6a - Browse repository at this point
Copy the full SHA 7fc4b6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a0f438 - Browse repository at this point
Copy the full SHA 5a0f438View commit details -
[wasm] Fix test filtering for debugger tests on windows (#63380)
This caused the disabled ArrayTests to run on windows, causing the builds to fail. With this change, the tests should correctly get skipped on windows.
Configuration menu - View commit details
-
Copy full SHA for 634dfa1 - Browse repository at this point
Copy the full SHA 634dfa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 44b9a6e - Browse repository at this point
Copy the full SHA 44b9a6eView commit details -
Fix time reporting for the merged tests (#63452)
In XUnitWrapperGenerator we need to initialize the stopwatch variable using Stopwatch.StartNew(), not just new Stopwatch(), otherwise the stopwatch never starts to run, that's why all the test case times showed as zero. (Alternatively we could use new Stopwatch() followed by stopwatch.Start() but I believe that Stopwatch.StartNew() is generally considered to be more performant.) After applying this fix, some short test times started reporting their running time in scientific notation (e.g. 5.5e-5) so I modified the formatting to F6 - in the Methodical suite I see a test running for 55 microseconds. Thanks Tomas
Configuration menu - View commit details
-
Copy full SHA for 599ab0e - Browse repository at this point
Copy the full SHA 599ab0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b7bef0 - Browse repository at this point
Copy the full SHA 0b7bef0View commit details -
Ensure UserSecretsIdAttribute is added to assembly (#63415)
When Microsoft.Extensions.Configuration.UserSecrets is referenced transitively, for example through Extensions.Hosting, the UserSecretsIdAttribute isn't getting added to the built assembly. This is because the logic is contained in a `build` folder which is excluded by the dependency from Extensions.Hosting. The fix is to move the logic to `buildTransitive`, so it gets picked up by NuGet. One wrinkle is that the logic now conflicts with the netstandard compatibility logic added by the library infrastructure. In order to make progress, disable that logic for this package and rely on its dependencies to raise the compat error. Contributes to #63246
Configuration menu - View commit details
-
Copy full SHA for 392b35c - Browse repository at this point
Copy the full SHA 392b35cView commit details -
Fix stack overflow with X509Certificate FriendlyName
A FriendlyName in Windows' length is a DWORD, an unsigned integer. We however marshal it as a signed integer, so a friendly name with a length greater than int.MaxValue would wrap around to negative. This in turn would be "below" the stackalloc threshold, and attempt to stackalloc a negative value. stackalloc treats this value as unsigned, so it results in allocating too much on the stack.
Configuration menu - View commit details
-
Copy full SHA for d988a52 - Browse repository at this point
Copy the full SHA d988a52View commit details -
[mono] Reorganize zlib dependency logic (#63365)
* [mono] Add back HAVE_SYS_ZLIB support In particular this re-enables embedded PDB support on iOS and Android * [mono] Reorganize zlib dependency logic Instead of deciding whether features are enabled based on the presence or absense of zlib, add switches to control features (embedded PDB support, and compressed log profiler output) and based on that require zlib. On some platforms we use the in-tree copy of zlib from src/native/external/zlib, otherwise we want to link against the system zlib. Previously, if zlib was missing the build would quietly succeed, but the feature support would be missing. Now, if the feature isn't disabled but zlib is missing, we fail the build. If both features are disabled, don't depend on zlib at all. * Fix typos Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com> * Style nits - reverse if() logic to avoid negation - use cmakedefine without a value in config.h.in, same as CoreCLR Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 0e800a6 - Browse repository at this point
Copy the full SHA 0e800a6View commit details -
Convert JIT/Methodical/Array/range Pri0 tests and hook up mobile test…
…ing (#62752) Co-authored-by: Tomas <trylek@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 90ec876 - Browse repository at this point
Copy the full SHA 90ec876View commit details -
Fix bugs with generation for ctor param default values (#62798)
* Fix bugs with generation for ctor param default values * Address review feedback * Address feedback
Configuration menu - View commit details
-
Copy full SHA for 98c5328 - Browse repository at this point
Copy the full SHA 98c5328View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0685e1 - Browse repository at this point
Copy the full SHA b0685e1View commit details -
[mono] Make some icalls pass/return object references using ObjectHan…
…dleOnStack/QCallTypeHandle (#62141) * [mono] Make some icalls return objects using an extra ObjectHandleOnStack argument. * Fix the passing of scalar vtypes on wasm. * Convert RuntimeTypeHandle icalls to receive a QCallTypeHandle. Also do some other cleanups: * Convert some icalls which don't receive/return objects any more and don't return an error to NOHANDLES. * Implement IsGenericVariable in managed code. * Add a separate GetMetadataToken icall to avoid the REUSE_WRAPPER stuff. * Sync the implementation of IsTypeDefinition with coreclr. * Convert some RuntimeType icalls to use QCallTypeHandles/ObjectHandleOnStack. * Fix RuntimeType.GetPacking () to work with dynamic types. * Convert internal_from_name to use QCallTypeHandles/ObjectHandleOnStack. * Convert more icalls. * Update src/libraries/System.Private.CoreLib/src/System/Runtime/CompilerServices/QCallHandles.cs Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com> * Remove unused argument from RuntimeTypeHandle:internal_from_name (). * Add support for FRAME_TYPE_IL_STATE to the metadata stack walker code. * Update coding style in QCallTypeHandle:.ctor (). * Revert "Convert more icalls." * Convert some Delegate icalls. * Convert some Enum icalls. * Convert some Marshal icalls. * Avoid creating RuntimeType objects while AOTing. * Convert some RuntimeType icalls. Co-authored-by: Aleksey Kliger (λgeek) <akliger@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 01cc900 - Browse repository at this point
Copy the full SHA 01cc900View commit details -
[DRAFT][Perf][Mono] Enable llvm for arm perf runs (#63311)
Enable llvm for arm perf runs.
Nathan Ricci authoredJan 6, 2022 Configuration menu - View commit details
-
Copy full SHA for 5993a3a - Browse repository at this point
Copy the full SHA 5993a3aView commit details -
JIT: save generics context for late devirtualization (#63420)
If we have a non-inline candidate call with generics context, save the context so it's available for late devirtualization. Fixes a missing devirtualization reported in #63283. I am deliberately leaving `LateDevirtualizationInfo` more general than necessary as it may serve as a jumping-off point for enabling late inlining.
Configuration menu - View commit details
-
Copy full SHA for a0220fd - Browse repository at this point
Copy the full SHA a0220fdView commit details
Commits on Jan 7, 2022
-
[Revert] Reverted change to global build job (#63483)
Nathan Ricci authoredJan 7, 2022 Configuration menu - View commit details
-
Copy full SHA for ef49cd0 - Browse repository at this point
Copy the full SHA ef49cd0View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff abb7df5...ef49cd0