Fix time reporting for the merged tests#63452
Merged
jkoritzinsky merged 1 commit intodotnet:mainfrom Jan 6, 2022
Merged
Conversation
In XUnitWrapperGenerator we need to initialize the stopwatch variable using Stopwatch.StartNew(), not just new Stopwatch(), otherwise the stopwatch never starts to run, that's why all the test case times showed as zero. (Alternatively we could use new Stopwatch() followed by stopwatch.Start() but I believe that Stopwatch.StartNew() is generally considered to be more performant.) After applying this fix, some short test times started reporting their running time in scientific notation (e.g. 5.5e-5) so I modified the formatting to F6 - in the Methodical suite I see a test running for 55 microseconds. Thanks Tomas
|
Tagging subscribers to this area: @hoyosjs Issue DetailsIn XUnitWrapperGenerator we need to initialize the stopwatch After applying this fix, some short test times started reporting Thanks Tomas
|
stephentoub
approved these changes
Jan 6, 2022
jkoritzinsky
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In XUnitWrapperGenerator we need to initialize the stopwatch
variable using Stopwatch.StartNew(), not just new Stopwatch(),
otherwise the stopwatch never starts to run, that's why all the
test case times showed as zero. (Alternatively we could use
new Stopwatch() followed by stopwatch.Start() but I believe that
Stopwatch.StartNew() is generally considered to be more
performant.)
After applying this fix, some short test times started reporting
their running time in scientific notation (e.g. 5.5e-5) so I
modified the formatting to F6 - in the Methodical suite I see
a test running for 55 microseconds.
Thanks
Tomas