Skip to content

[wasm] Fix test filtering for debugger tests on windows#63380

Merged
radical merged 1 commit intodotnet:mainfrom
radical:build-fixes
Jan 6, 2022
Merged

[wasm] Fix test filtering for debugger tests on windows#63380
radical merged 1 commit intodotnet:mainfrom
radical:build-fixes

Conversation

@radical
Copy link
Member

@radical radical commented Jan 5, 2022

This caused the disabled ArrayTests to run on windows, causing the builds to fail. With this change, the tests should correctly get skipped on windows.

@ghost
Copy link

ghost commented Jan 5, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned radical Jan 5, 2022
@radical radical changed the title [wasm][debugger][tests] fix filter arg for helix [wasm] Build fixes Jan 5, 2022
@radical
Copy link
Member Author

radical commented Jan 5, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 5, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 5, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 5, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jan 5, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical changed the title [wasm] Build fixes [wasm] Fix test filtering for debugger tests on windows Jan 6, 2022
@radical
Copy link
Member Author

radical commented Jan 6, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical removed their assignment Jan 6, 2022
@radical radical added arch-wasm WebAssembly architecture area-Debugger-mono labels Jan 6, 2022
@ghost
Copy link

ghost commented Jan 6, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This caused the disabled ArrayTests to run on windows, causing the builds to fail.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@radical radical marked this pull request as ready for review January 6, 2022 03:00
@radical
Copy link
Member Author

radical commented Jan 6, 2022

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical merged commit 634dfa1 into dotnet:main Jan 6, 2022
@radical radical deleted the build-fixes branch January 6, 2022 16:51
@ghost ghost locked as resolved and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Debugger-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants