-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Comparing changes
Open a pull request
base repository: dotnet/runtime
base: 8d007a7
head repository: dotnet/runtime
compare: ecd979c
- 6 commits
- 39 files changed
- 6 contributors
Commits on Nov 1, 2020
-
Delete unnecessary seek from SetLengthInternal on Unix (#44097)
Also, improve test coverage for FileStream.SetLength
Configuration menu - View commit details
-
Copy full SHA for c03edca - Browse repository at this point
Copy the full SHA c03edcaView commit details -
Add optimized String.Join for IList<string> (#44032)
* Support IList<string> * Revert API change * Feedback * Use ReadOnlySpan * Feedback * Fix comment * address feedback * Add test for List<string> optimization * Remove StartIndex and Count in core * Update src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs Co-authored-by: Stephen Toub <stoub@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for f1de95e - Browse repository at this point
Copy the full SHA f1de95eView commit details -
Fix type generator test failures (#44041)
- Fix issue where method token referred to derived type but method was actually defined on base type - Previously the methods did not carry enough state to determine when to emit the owner type of the method, and which exact type was the owning type. The new logic computes it from the token in the presence of a proper instantiation context, which allows for correct operation. - Fix issue where constrained dispatch on a method of a valuetype would not put in the correct owner type - Issue fixed by determining if the token resolves to a method on the same type as the eventual target method, or if it needs to have a specific owning type specified In general these issues where both caused by confusion around exactly the correct owning type, and it turned out that computation could not be computed within the signature emitter code, but instead needed to be computed in the JIT at point of use. Fortunately, we had a structure `MethodWithToken` that is used in these (and only these situations). Finally, I also made a pass through the emitter and related logic to remove various band-aids that had built up over the last few years to make all the tests and applications pass. I believe that the new logic should be correct in the general case. Bonus tweak... Use parallelism when compiling the framework composite images with crossgen2, and fix bug in composite image generation where mangled symbol names might conflict. Fixes #43466 and fixes #43467
Configuration menu - View commit details
-
Copy full SHA for 8560a2e - Browse repository at this point
Copy the full SHA 8560a2eView commit details -
1
Configuration menu - View commit details
-
Copy full SHA for df8e3f6 - Browse repository at this point
Copy the full SHA df8e3f6View commit details
Commits on Nov 2, 2020
-
Remove unsafe code from String.Join (#44126)
* Remove unsafe code from String.Join - Use a span for the separator to share the same code across a char separator and string separator, rather than using pointers. - Consolidate argument validation for the value/startIndex/count overloads into one shared helper - Change indexing to use standard 0 to values.Length for loop to eliminate bounds checking on span accesses * Update src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs
Configuration menu - View commit details
-
Copy full SHA for e10f771 - Browse repository at this point
Copy the full SHA e10f771View commit details -
(MQ cleanup) Remove size_t from managed Brotli code (#44043)
* Remove size_t from managed Brotli code * Apply suggestions from code review Co-authored-by: Stephen Toub <stoub@microsoft.com> Co-authored-by: Stephen Toub <stoub@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for ecd979c - Browse repository at this point
Copy the full SHA ecd979cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 8d007a7...ecd979c