(MQ cleanup) Remove size_t from managed Brotli code#44043
Merged
stephentoub merged 2 commits intodotnet:masterfrom Nov 2, 2020
Merged
(MQ cleanup) Remove size_t from managed Brotli code#44043stephentoub merged 2 commits intodotnet:masterfrom
stephentoub merged 2 commits intodotnet:masterfrom
Conversation
stephentoub
approved these changes
Oct 30, 2020
src/libraries/System.IO.Compression.Brotli/src/System/IO/Compression/enc/BrotliEncoder.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.IO.Compression.Brotli/src/System/IO/Compression/dec/BrotliDecoder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Member
|
@GrabYourPitchforks @stephentoub btw, maybe worth updating Brotli (1.0.7) to 1.0.9 (the latest google release)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces our custom size_t definition on the managed Brotli side with nuint. There's also a little bit of cleanup, adding calls to
Debug.Assertand using discards where appropriate.n.b. I'm using nuint instead of nint as a size_t replacement. This more closely matches that size_t is interpreted as an unsigned value.