Remove unsafe code from String.Join#44126
Merged
stephentoub merged 2 commits intodotnet:masterfrom Nov 2, 2020
Merged
Conversation
- Use a span for the separator to share the same code across a char separator and string separator, rather than using pointers. - Consolidate argument validation for the value/startIndex/count overloads into one shared helper - Change indexing to use standard 0 to values.Length for loop to eliminate bounds checking on span accesses
GrabYourPitchforks
approved these changes
Nov 1, 2020
src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs
Outdated
Show resolved
Hide resolved
stephentoub
commented
Nov 2, 2020
src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs
Outdated
Show resolved
Hide resolved
This was referenced Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @GrabYourPitchforks