Skip to content

ResxSourceGenerator: Changed the access modifier of the generated format methods from "internal" to "public" as it is with the generated properties.#7360

Closed
uo1 wants to merge 5 commits intodotnet:mainfrom
uo1:patch-1
Closed

ResxSourceGenerator: Changed the access modifier of the generated format methods from "internal" to "public" as it is with the generated properties.#7360
uo1 wants to merge 5 commits intodotnet:mainfrom
uo1:patch-1

Conversation

@uo1
Copy link

@uo1 uo1 commented Jul 24, 2024

Changed the access modifier of the format methods from "internal" to "public", like the generated properties are.
That also make it possible to access to those format methods from other assemblies, when the class is generated as public.

Fixes #7452

uo1 added 4 commits July 23, 2024 18:24
…mat methods to "public"

Changed the access modifier for format methods from "internal" to "public" like the properties are already. That makes it possible to access those methods from other assemblies too, when the class will be generated as public.
replaced "internal" access modifier for format method with "public"
replaced "internal" access modifier for format method with "public"
replaced "internal" access modifier for format method with "public"
@uo1 uo1 requested a review from a team as a code owner July 24, 2024 13:24
@uo1
Copy link
Author

uo1 commented Jul 24, 2024 via email

@codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.50%. Comparing base (7f449a5) to head (ebafee9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7360      +/-   ##
==========================================
- Coverage   96.50%   96.50%   -0.01%     
==========================================
  Files        1450     1450              
  Lines      347435   347435              
  Branches    11413    11413              
==========================================
- Hits       335297   335292       -5     
- Misses       9245     9250       +5     
  Partials     2893     2893              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@uo1 uo1 changed the title Changed the access modifier of the format methods from "internal" to "public", like the generated properties are. ResxSourceGenerator: Changed the access modifier of the format methods from "internal" to "public", like the generated properties are. Jul 30, 2024
@uo1 uo1 changed the title ResxSourceGenerator: Changed the access modifier of the format methods from "internal" to "public", like the generated properties are. ResxSourceGenerator: Changed the access modifier of the generated format methods from "internal" to "public" as it is with the generated properties. Jul 31, 2024
Copy link

@JustArchi JustArchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we're also blocked by this in entirely unrelated project, so merging would be welcome.

@uo1
Copy link
Author

uo1 commented Nov 6, 2024

Closes #7452

@uo1
Copy link
Author

uo1 commented Dec 12, 2024

@sharwell Could you please also take a look at this pull request? It would be great, if that issue could be solved soon.

@ViktorHofer ViktorHofer deleted the branch dotnet:main August 15, 2025 11:13
JoeRobich added a commit to dotnet/roslyn that referenced this pull request Aug 19, 2025
…mat methods from "internal" to "public" as it is with the generated properties. (#79941)

Changed the access modifier of the format methods from "internal" to
"public", like the generated properties are.
That also make it possible to access to those format methods from other
assemblies, when the class is generated as public.

Fixes dotnet/roslyn-analyzers#7452

This is the replacement for dotnet/roslyn-analyzers#7360 since the
ResxSourceGenerator have been moved to this repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResxSourceGenerator does not generate public format methods when Public="true" is set

3 participants