ResxSourceGenerator: Changed the access modifier of the generated format methods from "internal" to "public" as it is with the generated properties.#79941
Merged
JoeRobich merged 2 commits intodotnet:mainfrom Aug 19, 2025
Conversation
…ted properties. tests: updated resources accordingly to the changes.
JoeRobich
approved these changes
Aug 19, 2025
This was referenced Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the access modifier of the format methods from "internal" to "public", like the generated properties are.
That also make it possible to access to those format methods from other assemblies, when the class is generated as public.
Fixes dotnet/roslyn-analyzers#7452
This is the replacement for dotnet/roslyn-analyzers#7360 since the ResxSourceGenerator have been moved to this repository.