Move inheritance margin logic to a features service#83001
Merged
Conversation
CyrusNajmabadi
approved these changes
Mar 31, 2026
|
|
||
| Task<ImmutableArray<INamedTypeSymbol>> GetDerivedTypesAndImplementationsAsync( | ||
| INamedTypeSymbol typeSymbol, | ||
| Solution solution, |
Contributor
There was a problem hiding this comment.
Nit. Solution should be first. We try to order from widest to narrowest conceptual scope.
dibarbet
approved these changes
Apr 2, 2026
This was referenced Apr 2, 2026
JoeRobich
added a commit
that referenced
this pull request
Apr 7, 2026
Builds on #83001 Resolves #83008 https://github.com/user-attachments/assets/22131e46-3740-46c9-8213-0771ff38aa2a ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/83011)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a TypeHierarchyService in the Features layer which can be used for both Inheritance Margin and the LSP TypeHierarchy handlers.
Microsoft Reviewers: Open in CodeFlow