Merged
Conversation
786c0c6 to
f013072
Compare
dibarbet
approved these changes
Apr 6, 2026
| var solution = document.Project.Solution; | ||
| var typeSymbol = await TypeHierarchyHelpers.GetTypeSymbolAsync(request.Item, solution, cancellationToken).ConfigureAwait(false); | ||
| if (typeSymbol == null) | ||
| return null; |
Member
There was a problem hiding this comment.
Presumably this can fail if the workspace is edited so that the symbol no longer exists. Is the client smart enough to re-request information in this case, or should we throw LspErrorCodes.ContentModified (and is the client smart enough to handle that)?
Member
Author
There was a problem hiding this comment.
According to the LSP spec, Will return null if the server couldn’t infer a valid type from item in the params..
| var document = context.GetRequiredDocument(); | ||
| var solution = document.Project.Solution; | ||
| var typeSymbol = await TypeHierarchyHelpers.GetTypeSymbolAsync(request.Item, solution, cancellationToken).ConfigureAwait(false); | ||
| if (typeSymbol == null) |
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the following LSP APIs:
textDocument/prepareTypeHierarchytypeHierarchy/supertypestypeHierarchy/subtypesBuilds on #83001
Resolves #83008
Recording.2026-03-31.235757.mp4
Microsoft Reviewers: Open in CodeFlow