Skip to content

Port "Split if" refactorings' tests to Verify[CS|VB]#82892

Merged
JoeRobich merged 2 commits intodotnet:mainfrom
DoctorKrolic:split-if-tests
Apr 6, 2026
Merged

Port "Split if" refactorings' tests to Verify[CS|VB]#82892
JoeRobich merged 2 commits intodotnet:mainfrom
DoctorKrolic:split-if-tests

Conversation

@DoctorKrolic
Copy link
Copy Markdown
Contributor

@DoctorKrolic DoctorKrolic commented Mar 22, 2026

Microsoft Reviewers: Open in CodeFlow

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner March 22, 2026 13:33
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Mar 22, 2026
@DoctorKrolic DoctorKrolic changed the title Port "Split if" refactorings' tests to VerifyCS Port "Split if" refactorings' tests to Verify[CS|VB] Mar 22, 2026
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Thanks!

Copy link
Copy Markdown
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DoctorKrolic!

@DoctorKrolic
Copy link
Copy Markdown
Contributor Author

@JoeRobich Please merge

@JoeRobich JoeRobich merged commit 1d19196 into dotnet:main Apr 6, 2026
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 6, 2026
@jjonescz
Copy link
Copy Markdown
Member

jjonescz commented Apr 7, 2026

Looks like this broke main builds. Fix: #83085

jjonescz added a commit to jjonescz/roslyn that referenced this pull request Apr 7, 2026
The Split-if TopLevelStatement tests were still calling
TestInRegularAndScriptAsync after the base class was removed in dotnet#82892.
Convert them to use VerifyCS.Test with OutputKind.ConsoleApplication
and LanguageVersion.CSharp9 to match the top-level statement scenario.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jjonescz added a commit to jjonescz/roslyn that referenced this pull request Apr 7, 2026
The Split-if TopLevelStatement tests were still calling
TestInRegularAndScriptAsync after the base class was removed in dotnet#82892.
Convert them to use VerifyCS.Test with OutputKind.ConsoleApplication
and LanguageVersion.CSharp9 to match the top-level statement scenario.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jjonescz added a commit to jjonescz/roslyn that referenced this pull request Apr 7, 2026
The Split-if TopLevelStatement tests were still calling
TestInRegularAndScriptAsync after the base class was removed in dotnet#82892.
Convert them to use VerifyCS.Test with OutputKind.ConsoleApplication
and LanguageVersion.CSharp9 to match the top-level statement scenario.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@DoctorKrolic DoctorKrolic deleted the split-if-tests branch April 7, 2026 15:39
333fred pushed a commit that referenced this pull request Apr 7, 2026
…rn (#83085)

The Split-if TopLevelStatement tests were still calling
TestInRegularAndScriptAsync after the base class was removed in #82892.

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/dotnet/roslyn/pull/83085)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants