Fix incomplete migration of TopLevelStatement tests to VerifyCS pattern#83085
Merged
333fred merged 1 commit intodotnet:mainfrom Apr 7, 2026
Merged
Fix incomplete migration of TopLevelStatement tests to VerifyCS pattern#83085333fred merged 1 commit intodotnet:mainfrom
333fred merged 1 commit intodotnet:mainfrom
Conversation
| { | ||
| } | ||
| else | ||
| if (b) |
Contributor
There was a problem hiding this comment.
this is surprising behavior. i would not expect these to ever be on different lines.
Member
Author
There was a problem hiding this comment.
It looks like that's pre-existing behavior. The previous test was testing script parsing mode only though. Fixed.
The Split-if TopLevelStatement tests were still calling TestInRegularAndScriptAsync after the base class was removed in dotnet#82892. Convert them to use VerifyCS.Test with OutputKind.ConsoleApplication and LanguageVersion.CSharp9 to match the top-level statement scenario. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JoeRobich
approved these changes
Apr 7, 2026
333fred
approved these changes
Apr 7, 2026
Member
|
Bypassed requirements to unblock |
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Split-if TopLevelStatement tests were still calling TestInRegularAndScriptAsync after the base class was removed in #82892.
Microsoft Reviewers: Open in CodeFlow