Skip to content

Report error for ref field declared in type other than ref struct#62615

Merged
cston merged 3 commits intodotnet:mainfrom
cston:62596
Jul 13, 2022
Merged

Report error for ref field declared in type other than ref struct#62615
cston merged 3 commits intodotnet:mainfrom
cston:62596

Conversation

@cston
Copy link
Contributor

@cston cston commented Jul 13, 2022

Fixes #62596

@cston cston requested a review from a team as a code owner July 13, 2022 19:16
@ghost ghost added the Area-Compilers label Jul 13, 2022
@RikkiGibson
Copy link
Member

it's seriously the most mundane things we end up missing..

@jcouv jcouv self-assigned this Jul 13, 2022
@jcouv
Copy link
Member

jcouv commented Jul 13, 2022

Let's spend the time to scan and check the test plan: #59194

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@cston cston merged commit 99cc46f into dotnet:main Jul 13, 2022
@cston cston deleted the 62596 branch July 13, 2022 23:14
@ghost ghost added this to the Next milestone Jul 13, 2022
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 14, 2022
* upstream/main:
  Bind IterationErrorVariable to a natural type for error recovery (dotnet#62601)
  [main] Update dependencies from dotnet/source-build-externals (dotnet#61173)
  Cleanup: remove VisualStudioWorkspaceImpl.TryGetContainedDocument (dotnet#62616)
  EnC: A couple of small fixes (dotnet#62454)
  Report error for ref field declared in type other than ref struct (dotnet#62615)
  Store helpful info needed by incremental-generation on syntax-tree itself (dotnet#62551)
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No error for ref fields in non-ref structs

4 participants