Skip to content

Bind IterationErrorVariable to a natural type for error recovery#62601

Merged
333fred merged 2 commits intodotnet:mainfrom
333fred:iteration-error-type
Jul 14, 2022
Merged

Bind IterationErrorVariable to a natural type for error recovery#62601
333fred merged 2 commits intodotnet:mainfrom
333fred:iteration-error-type

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Jul 13, 2022

@333fred 333fred requested a review from a team as a code owner July 13, 2022 15:30
@ghost ghost added the Area-Compilers label Jul 13, 2022
@333fred
Copy link
Member Author

333fred commented Jul 13, 2022

@dotnet/roslyn-compiler for review.

@333fred 333fred added the Feature - Interpolated String Improvements Interpolated string improvements label Jul 13, 2022
@333fred
Copy link
Member Author

333fred commented Jul 14, 2022

@dotnet/roslyn-compiler for reviews please.

@jcouv jcouv self-assigned this Jul 14, 2022
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@333fred
Copy link
Member Author

333fred commented Jul 14, 2022

@dotnet/roslyn-compiler for a second review please.

@333fred 333fred merged commit 0b18d6c into dotnet:main Jul 14, 2022
@333fred 333fred deleted the iteration-error-type branch July 14, 2022 17:46
@ghost ghost added this to the Next milestone Jul 14, 2022
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 14, 2022
* upstream/main:
  Bind IterationErrorVariable to a natural type for error recovery (dotnet#62601)
  [main] Update dependencies from dotnet/source-build-externals (dotnet#61173)
  Cleanup: remove VisualStudioWorkspaceImpl.TryGetContainedDocument (dotnet#62616)
  EnC: A couple of small fixes (dotnet#62454)
  Report error for ref field declared in type other than ref struct (dotnet#62615)
  Store helpful info needed by incremental-generation on syntax-tree itself (dotnet#62551)
adamperlin pushed a commit to adamperlin/roslyn that referenced this pull request Jul 19, 2022
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants