Theme The "Generate Overrides" Dialog#62244
Merged
ryzngard merged 2 commits intodotnet:mainfrom Jul 1, 2022
Merged
Conversation
Youssef1313
suggested changes
Jun 29, 2022
Member
Youssef1313
left a comment
There was a problem hiding this comment.
Change signature and add parameter have the same issue:
It would be great if they're fixed as well.
Youssef1313
reviewed
Jun 29, 2022
JoeRobich
reviewed
Jun 29, 2022
| Grid.Row="1" | ||
| Header="{Binding ElementName=dialog, Path=PickMembersTitle}"> | ||
| Header="{Binding ElementName=dialog, Path=PickMembersTitle}" | ||
| Foreground="{DynamicResource {x:Static vs:ThemedDialogColors.HeaderTextBrushKey}}"> |
Member
There was a problem hiding this comment.
Is there a Theme color we should be using for the box Border?
Contributor
Author
There was a problem hiding this comment.
It seems to be automatically done with vs:ThemedDialogStyleLoader.UseDefaultThemedDialogStyles="True"
Contributor
Author
|
@Youssef1313 I'm working on themeing across the board. See an updated #55971 for some of these. I think what's left will be
I'll get those last 3 in another PR after #55971 gets in |
CyrusNajmabadi
approved these changes
Jul 1, 2022
333fred
added a commit
that referenced
this pull request
Jul 5, 2022
…ures/semi-auto-props * upstream/main: (887 commits) Ensure elastic trivia for reusable syntax in field generator (#62346) Fix typos in the incremental generators doc (#62343) Theme The "Generate Overrides" Dialog (#62244) Walk green-nodes in incremental-generator attribute-finding path (#62295) Cache the hash in compilation options (#62289) Respect dotnet_style_namespace_match_folder (#62310) Remove unreachable condition Specify builder capacities in incremental generation to avoid wasted scratch arrays. (#62285) Skip the test (#62287) Revert "Revert "Add Move Static Member To Existing Type (#61519)"" (#62284) Highlight the search term in the options page (#61301) Synch handlers with fix (#62209) Disable integration tests Fix Set capacity of builder to avoid expensive garbage. Add public APIs for opened and closed event handling for non-source documents Handle possible null symbols in `getAttributeTarget` (#62137) Perform a lookahead rather than a parsing attempt in order to determine if current token starts a conversion operator declaration. (#62240) Fix a race in CachingDictionary. (#62248) Simplify ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #61812
We were in a mix of themed and unthemed. This PR themes the entire dialog for use.
Original (Before Fix)
Blue Theme
Dark Theme